From: Rob Herring <robh@kernel.org>
To: Dylan Hung <dylan_hung@aspeedtech.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
linux-aspeed@lists.ozlabs.org,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, joel@jms.id.au, hkallweit1@gmail.com,
pabeni@redhat.com, linux-arm-kernel@lists.infradead.org,
andrew@aj.id.au, robh+dt@kernel.org, p.zabel@pengutronix.de,
krzk+dt@kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch,
BMC-SW@aspeedtech.com, linux@armlinux.org.uk,
davem@davemloft.net
Subject: Re: [PATCH v4 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding
Date: Tue, 12 Apr 2022 08:14:05 -0500 [thread overview]
Message-ID: <1649769245.688561.3815481.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220412065611.8930-2-dylan_hung@aspeedtech.com>
On Tue, 12 Apr 2022 14:56:09 +0800, Dylan Hung wrote:
> The AST2600 MDIO bus controller has a reset control bit and must be
> deasserted before manipulating the MDIO controller. By default, the
> hardware asserts the reset so the driver only need to deassert it.
>
> Regarding to the old DT blobs which don't have reset property in them,
> the reset deassertion is usually done by the bootloader so the reset
> property is optional to work with them.
>
> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.example.dts:25.35-36 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:364: Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1401: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-04-12 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 6:56 [PATCH v4 0/3] Add reset deassertion for Aspeed MDIO Dylan Hung
2022-04-12 6:56 ` [PATCH v4 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding Dylan Hung
2022-04-12 13:14 ` Rob Herring [this message]
2022-04-13 2:34 ` Joel Stanley
2022-04-13 2:59 ` Dylan Hung
2022-04-12 6:56 ` [PATCH v4 2/3] net: mdio: add reset control for Aspeed MDIO Dylan Hung
2022-04-12 14:24 ` Andrew Lunn
2022-04-12 6:56 ` [PATCH v4 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes Dylan Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1649769245.688561.3815481.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dylan_hung@aspeedtech.com \
--cc=hkallweit1@gmail.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox