The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "John Stoffel" <stoffel@lucent.com>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: "John Stoffel" <stoffel@lucent.com>,
	linux-kernel@vger.kernel.org, andre@linux-ide.org
Subject: Re: 2.6.5-rc3: cat /proc/ide/hpt366 kills disk on second channel
Date: Tue, 6 Apr 2004 14:35:51 -0400	[thread overview]
Message-ID: <16498.63623.379072.588962@gargle.gargle.HOWL> (raw)
In-Reply-To: <200404061900.36497.bzolnier@elka.pw.edu.pl>


Thanks Bart,

I'm compiling 2.6.3 right now with that patch and I'll let you know
how it goes.

Could it be that someone just mixed up the outb() and meant to use
inb() in that section?  I don't know the driver (or much kernel stuff)
in any detail.  Hmm... looking at it, it seems like they expect that
reading the cable info then requires your to mask some bits off and
then re-read to get the other port.  Whee...

I wonder how hard it would be to put in locking there.  I'll let you
know ASAP how well this fix works in the short run.

Should I try to look through all the various *_get_info() routines to
see if any others are doing outb() calls as well?

Heh... just looking at the code for aec62xx.c, should we be really
using pci_read_config_byte() instead of inb() in the hpt366.c code?

John


  reply	other threads:[~2004-04-06 18:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-05  0:00 2.6.5-rc3: cat /proc/ide/hpt366 kills disk on second channel John Stoffel
2004-04-06 16:06 ` John Stoffel
2004-04-06 17:00   ` Bartlomiej Zolnierkiewicz
2004-04-06 18:35     ` John Stoffel [this message]
2004-04-06 20:01     ` John Stoffel
2004-04-06 21:02       ` Bartlomiej Zolnierkiewicz
2004-04-07 15:41         ` John Stoffel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16498.63623.379072.588962@gargle.gargle.HOWL \
    --to=stoffel@lucent.com \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=andre@linux-ide.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox