From: Florian Fainelli <f.fainelli@gmail.com>
To: Antoine Tenart <antoine.tenart@bootlin.com>,
davem@davemloft.net, andrew@lunn.ch, hkallweit1@gmail.com
Cc: michael@walle.cc, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: mscc: fix Serdes configuration in vsc8584_config_init
Date: Fri, 5 Jun 2020 09:31:12 -0700 [thread overview]
Message-ID: <164ccc63-e06a-bf54-c1db-1bb74e79f20f@gmail.com> (raw)
In-Reply-To: <20200605140009.1352990-1-antoine.tenart@bootlin.com>
On 6/5/2020 7:00 AM, Antoine Tenart wrote:
> When converting the MSCC PHY driver to shared PHY packages, the Serdes
> configuration in vsc8584_config_init was modified to use 'base_addr'
> instead of 'base' as the port number. But 'base_addr' isn't equal to
> 'addr' for all PHYs inside the package, which leads to the Serdes still
> being enabled on those ports. This patch fixes it.
>
> Fixes: deb04e9c0ff2 ("net: phy: mscc: use phy_package_shared")
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-06-05 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 14:00 [PATCH net] net: phy: mscc: fix Serdes configuration in vsc8584_config_init Antoine Tenart
2020-06-05 16:31 ` Florian Fainelli [this message]
2020-06-05 20:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164ccc63-e06a-bf54-c1db-1bb74e79f20f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox