From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F49C433EF for ; Fri, 22 Apr 2022 09:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1446129AbiDVJdT (ORCPT ); Fri, 22 Apr 2022 05:33:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1446092AbiDVJdE (ORCPT ); Fri, 22 Apr 2022 05:33:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21F064EF6C; Fri, 22 Apr 2022 02:30:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B2CA661D65; Fri, 22 Apr 2022 09:30:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 05EA1C385AA; Fri, 22 Apr 2022 09:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650619811; bh=K4fhb+v7nuPqXAKuBPJ35RyTf0mZgN04+azTXGeyMfM=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=YvRlwerm6GgjtJfiDzbpG/rGCiX60naKJWC4rtofBpIUUAwplJyEWXjauyS3vU4dh aGWc6QGkuwspNt5cPZnZBQ7mv4TkBXoKEpaqkg4NJWx7SIN75FirzBMWdw7uZM03Qj pugVzeIcYL0BQaqROF9KEtuY6/Jjinyjg4k2PdCESkGAkPbY9BOm88TUMKnOm2Z/Kg gk7SL/jbMU0pHsq0GXygxsOQN1WYUDoQj06cAwsDKhmd8lyjf21dfkSAAxzJmrmaFO FYHE8Rzah9857QrmG4eW89rBuFPo9dBC9pV6rwHvQ3dkFc/uUUAaLQxweQxVpV1eRo 4gVjKxIrVJEWA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id D584FE8DD85; Fri, 22 Apr 2022 09:30:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: cosa: fix error check return value of register_chrdev() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165061981087.24106.7289646178993496759.git-patchwork-notify@kernel.org> Date: Fri, 22 Apr 2022 09:30:10 +0000 References: <20220418105834.2558892-1-lv.ruyi@zte.com.cn> In-Reply-To: <20220418105834.2558892-1-lv.ruyi@zte.com.cn> To: Lv Ruyi Cc: kas@fi.muni.cz, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lv.ruyi@zte.com.cn, zealci@zte.com.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Mon, 18 Apr 2022 10:58:34 +0000 you wrote: > From: Lv Ruyi > > If major equal 0, register_chrdev() returns error code when it fails. > This function dynamically allocate a major and return its number on > success, so we should use "< 0" to check it instead of "!". > > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi > > [...] Here is the summary with links: - net: cosa: fix error check return value of register_chrdev() https://git.kernel.org/netdev/net/c/d48fea8401cf You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html