* [PATCH] net: ethernet: mediatek: add missing of_node_put() in mtk_sgmii_init()
@ 2022-04-28 6:25 Yang Yingliang
2022-04-30 1:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-04-28 6:25 UTC (permalink / raw)
To: linux-kernel, netdev, linux-mediatek; +Cc: nbd, john, kuba, davem
The node pointer returned by of_parse_phandle() with refcount incremented,
so add of_node_put() after using it in mtk_sgmii_init().
Fixes: 9ffee4a8276c ("net: ethernet: mediatek: Extend SGMII related functions")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ethernet/mediatek/mtk_sgmii.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii.c b/drivers/net/ethernet/mediatek/mtk_sgmii.c
index 32d83421226a..5897940a418b 100644
--- a/drivers/net/ethernet/mediatek/mtk_sgmii.c
+++ b/drivers/net/ethernet/mediatek/mtk_sgmii.c
@@ -26,6 +26,7 @@ int mtk_sgmii_init(struct mtk_sgmii *ss, struct device_node *r, u32 ana_rgc3)
break;
ss->regmap[i] = syscon_node_to_regmap(np);
+ of_node_put(np);
if (IS_ERR(ss->regmap[i]))
return PTR_ERR(ss->regmap[i]);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: mediatek: add missing of_node_put() in mtk_sgmii_init()
2022-04-28 6:25 [PATCH] net: ethernet: mediatek: add missing of_node_put() in mtk_sgmii_init() Yang Yingliang
@ 2022-04-30 1:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-30 1:50 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-kernel, netdev, linux-mediatek, nbd, john, kuba, davem
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 28 Apr 2022 14:25:43 +0800 you wrote:
> The node pointer returned by of_parse_phandle() with refcount incremented,
> so add of_node_put() after using it in mtk_sgmii_init().
>
> Fixes: 9ffee4a8276c ("net: ethernet: mediatek: Extend SGMII related functions")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/ethernet/mediatek/mtk_sgmii.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- net: ethernet: mediatek: add missing of_node_put() in mtk_sgmii_init()
https://git.kernel.org/netdev/net/c/ff5265d45345
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-30 1:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-28 6:25 [PATCH] net: ethernet: mediatek: add missing of_node_put() in mtk_sgmii_init() Yang Yingliang
2022-04-30 1:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox