Re: [PATCH 1/9] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support

Dmitry Baryshkov
2022-05-11T16:52:20Z

On 11/05/2022 19:15, Sireesh Kodali wrote:
> Add support for the Audio DSP PIL found on the Qualcomm MSM8953
> platform. The same configuration is used on all SoCs based on the
> MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).
>
> Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 31 ++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 1ae47cc153e5..4dcb714a1468 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -617,7 +617,37 @@ static const struct adsp_data sm8350_adsp_resource = {
> .ssctl_id = 0x14,
> };
>
> +static const struct adsp_data msm8953_adsp_resource = {
> + .crash_reason_smem = 423,
> + .firmware_name = "adsp.mdt",
> + .pas_id = 1,
> + .has_aggre2_clk = false,
> + .auto_boot = true,
> + .proxy_pd_names = (char*[]){
> + "cx",
> + NULL,
> + },
> + .ssr_name = "lpass",
> + .sysmon_name = "adsp",
> + .ssctl_id = 0x14,
> +};
> +

Also it looks like this item is identical to msm8996_adsp_resources. So
you can existing structure instead.

> static const struct adsp_data msm8996_adsp_resource = {
> + .crash_reason_smem = 423,
> + .firmware_name = "adsp.mdt",
> + .pas_id = 1,
> + .has_aggre2_clk = false,
> + .auto_boot = true,
> + .proxy_pd_names = (char*[]){
> + "cx",
> + NULL,
> + },
> + .ssr_name = "lpass",
> + .sysmon_name = "adsp",
> + .ssctl_id = 0x14,
> +};
> +
> +static const struct adsp_data msm8998_adsp_resource = {
> .crash_reason_smem = 423,
> .firmware_name = "adsp.mdt",
> .pas_id = 1,
> @@ -850,6 +880,7 @@ static const struct adsp_data sdx55_mpss_resource = {
> static const struct of_device_id adsp_of_match[] = {
> { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
> { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource},
> + { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8953_adsp_resource},
> { .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init},
> { .compatible = "qcom,msm8998-adsp-pas", .data = &msm8996_adsp_resource},
> { .compatible = "qcom,msm8998-slpi-pas", .data = &slpi_resource_init},

--
With best wishes
Dmitry