From: Keith Owens <kaos@ocs.com.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
"Barry K. Nathan" <barryn@pobox.com>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [patch, -rc5-mm3] lock validator: fix ns83820.c irq-flags bug
Date: Sun, 04 Jun 2006 18:50:27 +1000 [thread overview]
Message-ID: <16537.1149411027@ocs3.ocs.com.au> (raw)
In-Reply-To: Your message of "Sun, 04 Jun 2006 10:30:17 +0200." <20060604083017.GA8241@elte.hu>
Ingo Molnar (on Sun, 4 Jun 2006 10:30:17 +0200) wrote:
>2) allowing the nesting of hardware interrupts only 'spreads out'
>the handling of the current ISR, causing extra cachemisses that would
>otherwise not happen. Furthermore, on architectures where ISRs share
>the kernel stacks, enabling interrupts in ISRs introduces a much
>higher kernel-stack-nesting and thus kernel-stack-overflow risk.
It is worse than you think. A third party network driver enabled
interrupts in its irq handler. For reasons that are still not clear,
that allowed recursive interrupts from the same device. Unexpected I
know, because the card's ISR should still have been masked, but the
stack trace said otherwise. When multiple packets arrived for the same
driver it drove multiple levels of kernel functions to handle them and
completely blew the kernel stack, even though it was using a separate
IRQ stack.
next prev parent reply other threads:[~2006-06-04 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 8:30 [patch, -rc5-mm3] lock validator: fix ns83820.c irq-flags bug Ingo Molnar
2006-06-04 8:50 ` Keith Owens [this message]
2006-06-04 8:58 ` Ingo Molnar
[not found] ` <1149411525.3109.73.camel@laptopd505.fenrus.org>
2006-06-04 9:53 ` [patch, -rc5-mm3] lock validator: fix ns83820.c irq-flags bug part 2 Barry K. Nathan
2006-06-04 10:08 ` [patch, -rc5-mm3] lock validator: fix ns83820.c irq-flags part 3 Arjan van de Ven
2006-06-04 10:11 ` Ingo Molnar
2006-06-04 10:16 ` Arjan van de Ven
2006-06-04 10:46 ` Barry K. Nathan
2006-06-04 11:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16537.1149411027@ocs3.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=barryn@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox