Re: [PATCH v5 2/3] dt-bindings: cros-ec: Reorganize property availability

Stephen Boyd
2022-05-16T19:32:29Z

Quoting Doug Anderson (2022-05-12 16:44:44)
> On Wed, May 11, 2022 at 6:39 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + not:
> > + contains:
> > + const: google,cros-ec-rpmsg
> > + then:
> > + properties:
> > + mediatek,rpmsg-name: false
> > +
> > + required:
> > + - reg
> > + - interrupts
>
> Is it worth having an "else" clause here? to explicitly make
> "mediatek,rpmsg-name" required for mediatek?

I don't know if mediatek,rpmsg-name is required for a generic
google,cros-ec-rpmsg. I would guess it isn't, because it's a vendor
prefixed property. Maybe it could look at the parent node property to
see that it is inside a mediatek remoteproc node but I'd rather leave
that to future work.

>
> In any case, this seems right from my (albeit) limited yaml knowledge
> and seems like an improvement.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks!