From: Rob Herring <robh@kernel.org>
To: Shreeya Patel <shreeya.patel@collabora.com>
Cc: devicetree@vger.kernel.org, alvaro.soliverez@collabora.com,
kernel@collabora.com, digetx@gmail.com, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, krisman@collabora.com,
jic23@kernel.org, Zhigang.Shi@liteon.com, lars@metafoo.de,
andy.shevchenko@gmail.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: Document ltrf216a light sensor bindings
Date: Wed, 08 Jun 2022 07:45:07 -0600 [thread overview]
Message-ID: <1654695907.399493.1272091.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220608113553.32083-2-shreeya.patel@collabora.com>
On Wed, 08 Jun 2022 17:05:52 +0530, Shreeya Patel wrote:
> Add devicetree bindings for ltrf216a ambient light sensor.
>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> ---
> Changes in v5
> - Remove deprecated string 'ltr' from the bindings.
>
> Changes in v3
> - Fix indentation in the example section
>
> Changes in v2
> - Take over the maintainership for the bindings
> - Add interrupt and power supply property in DT bindings
>
> .../bindings/iio/light/liteon,ltrf216a.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml: properties:compatible:const: ['liteon,ltrf216a'] is not of type 'string'
from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml: ignoring, error in schema: properties: compatible: const
Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.example.dtb:0:0: /example-0/i2c/light-sensor@53: failed to match any schema with compatible: ['liteon,ltrf216a']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-06-08 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 11:35 [PATCH v5 0/2] Add LTRF216A Driver Shreeya Patel
2022-06-08 11:35 ` [PATCH v5 1/2] dt-bindings: Document ltrf216a light sensor bindings Shreeya Patel
2022-06-08 13:45 ` Rob Herring [this message]
2022-06-08 11:35 ` [PATCH v5 2/2] iio: light: Add support for ltrf216a sensor Shreeya Patel
2022-06-08 16:16 ` Andy Shevchenko
2022-06-13 12:52 ` Shreeya Patel
2022-06-09 2:24 ` kernel test robot
2022-06-09 2:24 ` kernel test robot
2022-06-14 11:51 ` [PATCH v5 0/2] Add LTRF216A Driver Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1654695907.399493.1272091.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Zhigang.Shi@liteon.com \
--cc=alvaro.soliverez@collabora.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox