Re: [PATCH] KEYS: Make request_key() and co fundamentally asynchronous

Andrew Morton
2007-09-17T11:05:01Z

On Mon, 17 Sep 2007 11:56:00 +0100 David Howells <dhowells@redhat.com> wrote:

> > checkpatch generates a pile of warnings, all of which afacit are legit.
>
> For this warning:
>
> ERROR: need space after that ',' (ctx:WxV)
> #627: FILE: security/keys/internal.h:28:
> +#define kenter(FMT, ...) no_printk("==> %s("FMT")\n",__FUNCTION__ ,##__VA_ARGS__)
>
> ^
>
> This is with good reason. Some versions of cpp get the ## resolution "wrong"
> if __VA_ARGS__ is empty (ie: there are no arguments to the macro that
> correspond to the "..."). This can be worked around by abutting the "," the
> "##" and the "__VA_ARGS__" with no spaces, and inserting a space before the
> comma.

Tell me about it - I fixed that about 10000000000 times. Then we upped the
minimum required gcc version so it is no longer a problem.