From: David Howells <dhowells@redhat.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
Brian Behlendorf <behlendorf1@llnl.gov>,
Ben Woodard <bwoodard@llnl.gov>, Stable Team <stable@kernel.org>,
akpm@linux-foundation.org
Subject: Re: [Patch] rwsem: fix rwsem_is_locked() bug
Date: Mon, 05 Oct 2009 13:58:36 +0100 [thread overview]
Message-ID: <16559.1254747516@redhat.com> (raw)
In-Reply-To: <4AC99292.5060502@redhat.com>
Amerigo Wang <amwang@redhat.com> wrote:
> FYI, this seems wrong, probably even worse than what it is now.
> I tried this change, it breaks portmap.
Sorry, my mistake. The following:
> > - woken = 0;
> > + woken = ++sem->activity;
should have been:
- woken = 0;
+ woken = sem->activity++;
David
prev parent reply other threads:[~2009-10-05 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 3:19 [Patch] rwsem: fix rwsem_is_locked() bug Amerigo Wang
2009-09-30 23:08 ` Andrew Morton
2009-10-05 3:23 ` Amerigo Wang
2009-10-01 12:34 ` David Howells
2009-10-05 3:26 ` Amerigo Wang
2009-10-05 6:30 ` Amerigo Wang
2009-10-05 12:58 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16559.1254747516@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=behlendorf1@llnl.gov \
--cc=bwoodard@llnl.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox