Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add rtq6056 adc support

ChiYuan Huang
2022-06-29T08:59:47Z

Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年6月29日 週三 下午4:25寫道：
>
> On 29/06/2022 04:20, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add the documentation for Richtek rtq6056.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> > Since v2
> > - Change the resistor property name to be generic 'shunt-resistor-micro-ohms'.
> >
> > ---
> > .../bindings/iio/adc/richtek,rtq6056.yaml | 56 ++++++++++++++++++++++
> > 1 file changed, 56 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
> > new file mode 100644
> > index 00000000..fe45d8b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/adc/richtek,rtq6056.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: RTQ6056 Bi-Directional Current and Power Monitor with 16-bit ADC
> > +
> > +maintainers:
> > + - ChiYuan Huang <cy_huang@richtek.com>
> > +
> > +description: |
> > + The RTQ6056 is a high accuracy current-sense monitor with I2C and SMBus
> > + interface, and the device provides full information for system by reading
> > + out the loading current and power.
> > +
> > + The device monitors both of the drops across sense resistor and the BUS
> > + voltage, converts into the current in amperes, and power in watts through
> > + internal analog-to-digital converter ADC. The programmable calibration,
> > + adjustable conversion time, and averaging function are also built in for
> > + more design flexibility.
> > +
> > + Datasheet is available at
> > + https://www.richtek.com/assets/product_file/RTQ6056/DSQ6056-00.pdf
> > +
> > +properties:
> > + compatible:
> > + const: richtek,rtq6056
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + "#io-channel-cells":
> > + const: 1
> > +
> > + shunt-resistor-micro-ohms:
> > + description: Shunt IN+/IN- sensing node resistor
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - "#io-channel-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + rtq6056@40 {
>
> This was not fixed.
>
Sorry, too many changes to check. I really forgot it.
>
> Best regards,
> Krzysztof