From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499D2C43334 for ; Thu, 30 Jun 2022 10:00:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233551AbiF3KAS (ORCPT ); Thu, 30 Jun 2022 06:00:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233748AbiF3KAQ (ORCPT ); Thu, 30 Jun 2022 06:00:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CA7D43EDC; Thu, 30 Jun 2022 03:00:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1D5CE62195; Thu, 30 Jun 2022 10:00:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 72E02C385A5; Thu, 30 Jun 2022 10:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656583214; bh=BWLfKsPSN4yajyxIhFyOTTZXdy8Ooyjrk8lujMp6r2c=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=f6DaFtzD5/f1u+5kOT5ozyzBVPm9bJRcngnEXaYSPfZfqSF2KpUI8y8MC9wppKFdy CLynIjl+WvcRfTy1QGWGU5KJoo8gmgCbaUZ5VIAkNv0DbaFHpjFX+pNPAzxjdegKK5 4toWaQ9DmoQqycHfQz+Cfa81Eqw5zqih6sxMYfmtBTm/cAsfUT/HdfCxpl+VbMGJHn hPAWa5aA2mzhlbtE9fAOTRtwcnjXobdENzG8Gd+3lLA/3jA1Uwt8Ul6Wxr1HT70YBy Jda3W+FFvz7raA4JogWkAZCMXY1HlaaFSa2HtjvVKY4tHVzs5HP9q87hhjmrKJtatY PN1pk2nSZCdPA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 5252EE49FA0; Thu, 30 Jun 2022 10:00:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v3] net: sfp: fix memory leak in sfp_probe() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165658321433.30282.12130648369067340647.git-patchwork-notify@kernel.org> Date: Thu, 30 Jun 2022 10:00:14 +0000 References: <20220629075550.2152003-1-niejianglei2021@163.com> In-Reply-To: <20220629075550.2152003-1-niejianglei2021@163.com> To: Jianglei Nie Cc: linux@armlinux.org.uk, andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni : On Wed, 29 Jun 2022 15:55:50 +0800 you wrote: > sfp_probe() allocates a memory chunk from sfp with sfp_alloc(). When > devm_add_action() fails, sfp is not freed, which leads to a memory leak. > > We should use devm_add_action_or_reset() instead of devm_add_action(). > > Signed-off-by: Jianglei Nie > > [...] Here is the summary with links: - [net,v3] net: sfp: fix memory leak in sfp_probe() https://git.kernel.org/netdev/net/c/0a18d802d65c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html