From: patchwork-bot+netdevbpf@kernel.org
To: Xin Xiong <xiongx18@fudan.edu.cn>
Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
praveen5582@gmail.com, zxu@linkedin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, yuanxzhang@fudan.edu.cn,
tanxin.ctf@gmail.com
Subject: Re: [PATCH] net: fix potential refcount leak in ndisc_router_discovery()
Date: Mon, 15 Aug 2022 10:50:13 +0000 [thread overview]
Message-ID: <166056061390.20212.5869065400117600776.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220813124907.3396-1-xiongx18@fudan.edu.cn>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Sat, 13 Aug 2022 20:49:08 +0800 you wrote:
> The issue happens on specific paths in the function. After both the
> object `rt` and `neigh` are grabbed successfully, when `lifetime` is
> nonzero but the metric needs change, the function just deletes the
> route and set `rt` to NULL. Then, it may try grabbing `rt` and `neigh`
> again if above conditions hold. The function simply overwrite `neigh`
> if succeeds or returns if fails, without decreasing the reference
> count of previous `neigh`. This may result in memory leaks.
>
> [...]
Here is the summary with links:
- net: fix potential refcount leak in ndisc_router_discovery()
https://git.kernel.org/netdev/net/c/7396ba87f1ed
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2022-08-15 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 12:49 [PATCH] net: fix potential refcount leak in ndisc_router_discovery() Xin Xiong
2022-08-15 10:50 ` patchwork-bot+netdevbpf [this message]
2022-08-15 18:03 ` Praveen Chaudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166056061390.20212.5869065400117600776.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praveen5582@gmail.com \
--cc=tanxin.ctf@gmail.com \
--cc=xiongx18@fudan.edu.cn \
--cc=yoshfuji@linux-ipv6.org \
--cc=yuanxzhang@fudan.edu.cn \
--cc=zxu@linkedin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox