Re: [PATCH v3 2/2] power: supply: rt9471: Add Richtek RT9471 charger driver

ChiYuan Huang
2022-08-18T10:31:03Z

Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年8月18日 週四 下午6:18寫道：
>
> On 18/08/2022 13:16, ChiYuan Huang wrote:
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年8月18日 週四 下午4:09寫道：
> >>
> >> On 18/08/2022 04:21, cy_huang wrote:
> >>> From: ChiYuan Huang <cy_huang@richtek.com>
> >>>
> >>> Add support for the RT9471 3A 1-Cell Li+ battery charger.
> >>>
> >>> The RT9471 is a highly-integrated 3A switch mode battery charger with
> >>> low impedance power path to better optimize the charging efficiency.
> >>>
> >>> Co-developed-by: Alina Yu <alina_yu@richtek.com>
> >>> Signed-off-by: Alina Yu <alina_yu@richtek.com>
> >>> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> >>> ---
> >>> Since v2:
> >>> - Fix checkpatch error about 'foo * bar' to 'foo *bar' in psy_device_to_chip function.
> >>> - Specify the member name directly for the use of linear range.
> >>>
> >>> ---
> >>
> >> (...)
> >>
> >>> +
> >>> +static DEVICE_ATTR_RW(sysoff_enable);
> >>> +static DEVICE_ATTR_RW(charge_term_enable);
> >>> +static DEVICE_ATTR_RW(port_detect_enable);
> >>> +
> >>> +static struct attribute *rt9471_sysfs_entries[] = {
> >>> + &dev_attr_sysoff_enable.attr,
> >>> + &dev_attr_charge_term_enable.attr,
> >>> + &dev_attr_port_detect_enable.attr,
> >>> + NULL
> >>
> >> You need to document the sysfs ABI in Documentation.
> > Can it be define in 'sysfs-class-power' or a dedicated file called
> > 'sysfs-class-power-rt9471'?
> > Not sure which one is better.
>
> I don't know what is Sebastian's preference. You can wait for his input
> or do similarly as last patches reviewed/picked up by him.
M... OK.
Whatever the preference is, at least, I can prepare the ABI contents first.
>
> Best regards,
> Krzysztof