Re: [PATCH] usb: dwc2: remove incomplete DMA support from gadget code

[Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>]

Hi,

On Tuesday, July 08, 2014 08:04:47 PM Paul Zimmerman wrote:
> > From: Bartlomiej Zolnierkiewicz [mailto:b.zolnierkie@samsung.com]
> > Sent: Tuesday, July 08, 2014 7:55 AM
> > 
> > The commit 5b7d70c6dbf2 ("USB: Gadget driver for Samsung HS/OtG
> > block") which added this driver also introduced the inactive DMA
> > support (due to hardware limitations of DMA buffers alignment).
> > It has been a dead code for over 5 years and should be removed.
> > 
> > We don't keep the unused/untested features in the kernel.  Such
> > code has a real maintainance cost (all other changes have to take
> > dead code into account), i.e. https://lkml.org/lkml/2014/5/6/461.
> > Also all the removed dead code is still accessible in the kernel
> > git repository and can be easily brought back if/when needed.
> > 
> > There should be no functional changes caused by this patch.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> 
> Hmm. I'd rather not apply this for the time being. Dinh Nguyen is
> working on a patch to combine the two dwc2 drivers into a dual-role
> driver. I suspect his platform will be able to use DMA. Also, once that
> is done, I plan to enable device-mode support for the Synopsys
> development platform, which also supports DMA.
> 
> If none of this happens over the next couple of months, we can reconsider
> applying this patch. After all, the code has been there for 5 years, a
> couple more months won't hurt. Sound OK?

Well, I would prefer to have it removed now instead of hoping that some
new platforms will have DMA limitations lifted.  DMA code can be easily
brought back when needed and it needs to be verified on new hardware
anyway..

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics