public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tom Zanussi <zanussi@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/5] tracing/hist: Add percentage histogram suffixes
Date: Sat, 27 Aug 2022 13:03:05 +0900	[thread overview]
Message-ID: <166157298537.348924.2537162090505397377.stgit@devnote2> (raw)

Hi,

Here is the 4th version of .percent and .graph suffixes for histogram
trigger to show the value in percentage and in bar-graph respectively.

I've rebased on Tom's hitcount patch[1/5] on the series and added a patch
for supressing display of hitcount[5/5] in this version.

This will help us to check the trend of the histogram instantly
without any post processing tool.

Here shows an example of the percentage and the bar graph of
the hitcount of the running tasks.

  # cd /sys/kernel/debug/tracing/
  # echo hist:keys=pid:vals=hitcount.percent,hitcount.graph:sort=pid > \
        events/sched/sched_stat_runtime/trigger
  # sleep 10
  # cat events/sched/sched_stat_runtime/hist
 # event histogram
 #
 # trigger info: hist:keys=pid:vals=hitcount.percent,hitcount.graph:sort=pid:size=2048 [active]
 #

 { pid:         14 } hitcount (%):   4.68  hitcount: ###                 
 { pid:         16 } hitcount (%):  17.18  hitcount: ###########         
 { pid:         57 } hitcount (%):   7.81  hitcount: #####               
 { pid:         61 } hitcount (%):  31.25  hitcount: ####################
 { pid:         70 } hitcount (%):   4.68  hitcount: ###                 
 { pid:         77 } hitcount (%):   1.56  hitcount: #                   
 { pid:        145 } hitcount (%):  18.75  hitcount: ############        
 { pid:        151 } hitcount (%):   9.37  hitcount: ######              
 { pid:        152 } hitcount (%):   4.68  hitcount: ###                 

 Totals:
     Hits: 64
     Entries: 9
     Dropped: 0

Of course if you explicitly specify the hitcount, it can show the
hitcount as below;

  # cd /sys/kernel/debug/tracing/
  # echo hist:keys=pid:vals=hitcount,runtime:sort=pid > \
        events/sched/sched_stat_runtime/trigger
  # sleep 10
  # cat events/sched/sched_stat_runtime/hist
 # event histogram
 #
 # trigger info: hist:keys=pid:vals=hitcount,runtime:sort=pid:size=2048 [active]
 #

 { pid:         14 } hitcount:          2  runtime:     304876
 { pid:         16 } hitcount:          8  runtime:     300574
 { pid:         26 } hitcount:          2  runtime:      15578
 { pid:         32 } hitcount:          2  runtime:     219186
 { pid:         57 } hitcount:          3  runtime:     506003
 { pid:         61 } hitcount:         20  runtime:    1681473
 { pid:         69 } hitcount:          3  runtime:     201785
 { pid:         70 } hitcount:          4  runtime:     360608
 { pid:         77 } hitcount:          8  runtime:    4146935
 { pid:        145 } hitcount:         13  runtime:    7537994
 { pid:        155 } hitcount:          4  runtime:    2511937
 { pid:        156 } hitcount:          2  runtime:    1398886

 Totals:
     Hits: 71
     Entries: 12
     Dropped: 0


Thank you,

---

Masami Hiramatsu (Google) (4):
      tracing: Fix to check event_mutex is held while accessing trigger list
      tracing: Add .percent suffix option to histogram values
      tracing: Add .graph suffix option to histogram value
      tracing: Show hitcount value only when specified

Tom Zanussi (1):
      tracing: Allow multiple hitcount values in histograms


 kernel/trace/trace.c                |    3 -
 kernel/trace/trace_events_hist.c    |  176 ++++++++++++++++++++++++++++++-----
 kernel/trace/trace_events_trigger.c |    3 -
 3 files changed, 156 insertions(+), 26 deletions(-)

--
Masami Hiramatsu (Google) <mhiramat@kernel.org>

             reply	other threads:[~2022-08-27  4:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-27  4:03 Masami Hiramatsu (Google) [this message]
2022-08-27  4:03 ` [PATCH v4 1/5] tracing: Allow multiple hitcount values in histograms Masami Hiramatsu (Google)
2022-08-27  4:03 ` [PATCH v4 2/5] tracing: Fix to check event_mutex is held while accessing trigger list Masami Hiramatsu (Google)
2022-08-27  4:03 ` [PATCH v4 3/5] tracing: Add .percent suffix option to histogram values Masami Hiramatsu (Google)
2022-08-27  4:03 ` [PATCH v4 4/5] tracing: Add .graph suffix option to histogram value Masami Hiramatsu (Google)
2022-08-27  4:03 ` [PATCH v4 5/5] tracing: Show hitcount value only when specified Masami Hiramatsu (Google)
2022-08-31 21:35 ` [PATCH v4 0/5] tracing/hist: Add percentage histogram suffixes Tom Zanussi
2022-08-31 23:02   ` Masami Hiramatsu
2022-09-01 20:59     ` Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166157298537.348924.2537162090505397377.stgit@devnote2 \
    --to=mhiramat@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox