From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tom Zanussi <zanussi@kernel.org>, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v5 0/6] tracing/hist: Add percentage histogram suffixes
Date: Sun, 4 Sep 2022 13:12:11 +0900 [thread overview]
Message-ID: <166226473132.223837.9011128463174539022.stgit@devnote2> (raw)
Hi,
Here is the 5th version of .percent and .graph suffixes for histogram
trigger to show the value in percentage and in bar-graph respectively.
The previous version is here;
https://lore.kernel.org/all/166157298537.348924.2537162090505397377.stgit@devnote2
This version updated the last patch to add "nohitcount" option for
supressing display of hitcount according to Tom's suggestion[5/6],
fix README file[4/6], and update the histogram document[6/6].
This will help us to check the trend of the histogram instantly
without any post processing tool.
Here shows an example of the percentage and the bar graph of
the runtime of the running tasks without raw hitcount field.
# cd /sys/kernel/debug/tracing/
# echo hist:keys=pid:vals=hitcount.percent,hitcount.graph:sort=pid:NOHC > \
events/sched/sched_stat_runtime/trigger
# sleep 10
# cat events/sched/sched_stat_runtime/hist
# event histogram
#
# trigger info: hist:keys=pid:vals=hitcount.percent,hitcount.graph:sort=pid:size=2048:nohitcount [active]
#
{ pid: 14 } hitcount (%): 6.91 hitcount: ##
{ pid: 16 } hitcount (%): 1.13 hitcount:
{ pid: 57 } hitcount (%): 6.99 hitcount: ##
{ pid: 61 } hitcount (%): 55.28 hitcount: ####################
{ pid: 67 } hitcount (%): 5.52 hitcount: ##
{ pid: 69 } hitcount (%): 20.08 hitcount: #######
{ pid: 71 } hitcount (%): 0.40 hitcount:
{ pid: 77 } hitcount (%): 0.97 hitcount:
{ pid: 78 } hitcount (%): 0.56 hitcount:
{ pid: 145 } hitcount (%): 1.13 hitcount:
{ pid: 153 } hitcount (%): 0.48 hitcount:
{ pid: 154 } hitcount (%): 0.48 hitcount:
Totals:
Hits: 1230
Entries: 12
Dropped: 0
With the NOHC (or nohitcount) option, the histogram will skip
display of raw hitcount, but it will allow to display percent
and graph of hitcount.
Trigger Result
val=runtime -> Show hitcount and runtime
val=runtime:NOHC -> Show runtime
val=hitcount:NOHC -> Error
(noval) -> show hitcount
(noval):NOHC -> Error
val=hitcount.parcent -> show hitcount and hitcount%
val=hitcount.parcent:NOHC -> show hitcount%
Thank you,
---
Masami Hiramatsu (Google) (5):
tracing: Fix to check event_mutex is held while accessing trigger list
tracing: Add .percent suffix option to histogram values
tracing: Add .graph suffix option to histogram value
tracing: Add nohitcount option for suppressing display of raw hitcount
tracing: docs: Update histogram doc for .percent/.graph and 'nohitcount'
Tom Zanussi (1):
tracing: Allow multiple hitcount values in histograms
Documentation/trace/histogram.rst | 10 ++
kernel/trace/trace.c | 7 +
kernel/trace/trace_events_hist.c | 177 ++++++++++++++++++++++++++++++-----
kernel/trace/trace_events_trigger.c | 3 -
4 files changed, 171 insertions(+), 26 deletions(-)
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next reply other threads:[~2022-09-04 4:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 4:12 Masami Hiramatsu (Google) [this message]
2022-09-04 4:12 ` [PATCH v5 1/6] tracing: Allow multiple hitcount values in histograms Masami Hiramatsu (Google)
2022-09-07 2:03 ` Steven Rostedt
2022-09-07 6:12 ` Masami Hiramatsu
2022-09-04 4:12 ` [PATCH v5 2/6] tracing: Fix to check event_mutex is held while accessing trigger list Masami Hiramatsu (Google)
2022-09-07 2:09 ` Steven Rostedt
2022-09-04 4:12 ` [PATCH v5 3/6] tracing: Add .percent suffix option to histogram values Masami Hiramatsu (Google)
2022-09-04 4:12 ` [PATCH v5 4/6] tracing: Add .graph suffix option to histogram value Masami Hiramatsu (Google)
2022-09-04 4:12 ` [PATCH v5 5/6] tracing: Add nohitcount option for suppressing display of raw hitcount Masami Hiramatsu (Google)
2022-09-04 4:13 ` [PATCH v5 6/6] tracing: docs: Update histogram doc for .percent/.graph and 'nohitcount' Masami Hiramatsu (Google)
2022-09-08 22:01 ` [PATCH v5 0/6] tracing/hist: Add percentage histogram suffixes Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166226473132.223837.9011128463174539022.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox