From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755703AbbCRPDf (ORCPT ); Wed, 18 Mar 2015 11:03:35 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:58320 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754803AbbCRPDc (ORCPT ); Wed, 18 Mar 2015 11:03:32 -0400 X-AuditID: cbfee61b-f79d76d0000024d6-91-550993c20d6c From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Kukjin Kim , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Daniel Lezcano , Tomasz Figa , linux-kernel@vger.kernel.org, Kyungmin Park , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/4] ARM: EXYNOS: cpuidle: add AFTR mode support for Exynos3250 Date: Wed, 18 Mar 2015 16:03:27 +0100 Message-id: <1662403.kKJKYQxI82@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-70-generic-pae; KDE/4.8.5; i686; ; ) In-reply-to: References: <1426683113-31209-1-git-send-email-b.zolnierkie@samsung.com> <1426683113-31209-4-git-send-email-b.zolnierkie@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=UTF-8 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsVy+t9jAd1DkzlDDVo3mFrM+yxr8fqFoUXv gqtsFv2PXzNbnG16w26x6fE1VovLu+awWXzuPcJoMeP8PiaLVbv+MDpweeycdZfdY9OqTjaP O9f2sHlsXlLv0bdlFaPH501yAWxRXDYpqTmZZalF+nYJXBnn7rxnKljCWfF48gfmBsbT7F2M nBwSAiYSF38dg7LFJC7cW8/WxcjFISSwiFHi6u/9LBBOC5NEy/VrTCBVbAJWEhPbVzGC2CIC hhIHd28HizMLnGKSOL+2HMQWFoiQmLm2A6yGRUBV4vmsbWAbeAU0Ja59WgxWLyrgKbFz+gGw Gk6BYIlTaz+yQyw7xyhxee0dNogGQYkfk++xQCyQl9i3fyorhK0uMWneIuYJjAKzkJTNQlI2 C0nZAkbmVYyiqQXJBcVJ6blGesWJucWleel6yfm5mxjBsfBMegfjqgaLQ4wCHIxKPLwSVzlC hVgTy4orcw8xSnAwK4nwVjdyhgrxpiRWVqUW5ccXleakFh9ilOZgURLnVbJvCxESSE8sSc1O TS1ILYLJMnFwSjUwBua+XVeolv3ZZ/vvBXvfPl1b+pxxre6aqFz21adFJWacOFq51fn4+pyZ EhEejla7P5eumMVuxPt3wR29Df+T47t+vZ8jK6J6tUuls7DKXZllpc7B8Kfi19aKfZmSox55 l7W7dt2aJ98PFMbE//DtNrpdeORm6K2kgFsslYH71M5UGdQKLtp6WomlOCPRUIu5qDgRAH8F +B+BAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, March 18, 2015 02:38:26 PM Krzysztof Kozlowski wrote: > 2015-03-18 13:51 GMT+01:00 Bartlomiej Zolnierkiewicz : > > The patchset itself looks good... but it's missing commit message. > What benefits does the AFTR bring? AFTR support brings reduced energy consumption and is a prerequisite for more advanced W-AFTR/LPA power saving modes. AFTR has been already supported on other Exynos SoCs for few years so there is really no need to explain its purpose with every new SoC support addition. [ Moreover you know this all really well since we've worked together on many Exynos Power Management issues :). ] I understand that you are complaining about skimpy commit message and I can certainly improve it (however personally I think that it will not bring much benefit because the patch is rather straightforward one). Please also note that while I appreciate review comments please try to make them more substantial and bring them earlier (this patchset hasn't really changed since v1 which was posted in October 2014). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics