From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933190AbcA0OKe (ORCPT ); Wed, 27 Jan 2016 09:10:34 -0500 Received: from gloria.sntech.de ([95.129.55.99]:60850 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932541AbcA0OK2 (ORCPT ); Wed, 27 Jan 2016 09:10:28 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Linus Walleij Cc: David Wu , huangtao@rock-chips.com, Chris Zhong , Eddie Cai , xjq@rock-chips.com, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , David Wu Subject: Re: [PATCH v2] pinctrl: rockchip: add support for the rk3399 Date: Wed, 27 Jan 2016 15:10:19 +0100 Message-ID: <1664345.86tvmnNB3Q@diego> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: References: <1451997055-47655-1-git-send-email-wdc@rock-chips.com> <1452152498-21780-1-git-send-email-wdc@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 27. Januar 2016, 15:02:18 schrieb Linus Walleij: > On Thu, Jan 7, 2016 at 8:41 AM, David Wu wrote: > > From: David Wu > > > > The pinctrl of rk3399 is much different from other's, > > especially the 3bits of drive strength. > > > > Signed-off-by: David Wu > > --- > > change from v1: > > - need spin_unlock_irqrestore for set drive default case > > Heiko can you please look at this patch? sorry, about that falling so far down my inbox. I'll try to look at it today or tomorrow. But overall it looks good. @David: if you wake up before I manage to review more in-depth, the "reading register twice" (+writing counterpart) + /* need to read regs twice */ + ret = regmap_read(regmap, reg, &temp); + if (ret) + return ret; should definitly get more explanation on how that access scheme works. Seems to be some special register access method with the register returning different values each time? As I don't have a manual for the soc yet this is definitly curious for me :-) > > > + { .compatible = "rockchip,rk3399-pinctrl", > > + .data = (void *)&rk3399_pin_ctrl }, > > I guess this requires a small patch to some binding file. > It's OK to fold that into this patch. @David: Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.txt