public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
	<jinpu.wang@cloud.ionos.com>, <damien.lemoal@wdc.com>
Cc: <hare@suse.de>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
	<ipylypiv@google.com>, <changyuanl@google.com>,
	John Garry <john.garry@huawei.com>
Subject: [PATCH v4 1/7] scsi: libsas: Add sas_task_find_rq()
Date: Tue, 18 Oct 2022 19:15:57 +0800	[thread overview]
Message-ID: <1666091763-11023-2-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1666091763-11023-1-git-send-email-john.garry@huawei.com>

blk-mq already provides a unique tag per request. Some libsas LLDDs - like
hisi_sas - already use this tag as the unique per-IO HW tag.

Add a common function to provide the request associated with a sas_task
for all libsas LLDDs.

Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
 include/scsi/libsas.h | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
index ec6c9ecd8d12..1aee3d0ebbb2 100644
--- a/include/scsi/libsas.h
+++ b/include/scsi/libsas.h
@@ -644,6 +644,24 @@ static inline bool sas_is_internal_abort(struct sas_task *task)
 	return task->task_proto == SAS_PROTOCOL_INTERNAL_ABORT;
 }
 
+static inline struct request *sas_task_find_rq(struct sas_task *task)
+{
+	struct scsi_cmnd *scmd;
+
+	if (task->task_proto & SAS_PROTOCOL_STP_ALL) {
+		struct ata_queued_cmd *qc = task->uldd_task;
+
+		scmd = qc ? qc->scsicmd : NULL;
+	} else {
+		scmd = task->uldd_task;
+	}
+
+	if (!scmd)
+		return NULL;
+
+	return scsi_cmd_to_rq(scmd);
+}
+
 struct sas_domain_function_template {
 	/* The class calls these to notify the LLDD of an event. */
 	void (*lldd_port_formed)(struct asd_sas_phy *);
-- 
2.35.3


  reply	other threads:[~2022-10-18 10:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 11:15 [PATCH v4 0/7] scsi: libsas: Use request tag in more drivers John Garry
2022-10-18 11:15 ` John Garry [this message]
2022-10-18 11:15 ` [PATCH v4 2/7] scsi: hisi_sas: Use sas_task_find_rq() John Garry
2022-10-18 11:15 ` [PATCH v4 3/7] scsi: hisi_sas: Put reserved tags in lower region of tagset John Garry
2022-10-18 12:02   ` Hannes Reinecke
2022-10-18 11:16 ` [PATCH v4 4/7] scsi: pm8001: Remove pm8001_tag_init() John Garry
2022-10-18 11:16 ` [PATCH v4 5/7] scsi: pm8001: Use sas_task_find_rq() for tagging John Garry
2022-10-18 12:03   ` Hannes Reinecke
2022-10-18 11:16 ` [PATCH v4 6/7] scsi: mvsas: Delete mvs_tag_init() John Garry
2022-10-18 11:16 ` [PATCH v4 7/7] scsi: mvsas: Use sas_task_find_rq() for tagging John Garry
2022-10-22  3:05 ` [PATCH v4 0/7] scsi: libsas: Use request tag in more drivers Martin K. Petersen
2022-10-27  2:58 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1666091763-11023-2-git-send-email-john.garry@huawei.com \
    --to=john.garry@huawei.com \
    --cc=changyuanl@google.com \
    --cc=damien.lemoal@wdc.com \
    --cc=hare@suse.de \
    --cc=ipylypiv@google.com \
    --cc=jejb@linux.ibm.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox