From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tom Zanussi <zanussi@kernel.org>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v6 0/5] tracing/hist: Add percentage histogram suffixes
Date: Wed, 19 Oct 2022 00:48:33 +0900 [thread overview]
Message-ID: <166610811353.56030.10023036046735082272.stgit@devnote2> (raw)
Hi,
Sorry, I forgot to update this series.
Here is the 6th version of .percent and .graph suffixes for histogram
trigger to show the value in percentage and in bar-graph respectively.
The previous version is here;
https://lore.kernel.org/all/166226473132.223837.9011128463174539022.stgit@devnote2
This is just fixing to add my signed-off-by and Tom's reviewed/tested-by.
No functional changes.
Here shows an example of the percentage and the bar graph of
the runtime of the running tasks without raw hitcount field.
# cd /sys/kernel/debug/tracing/
# echo hist:keys=pid:vals=hitcount.percent,hitcount.graph:sort=pid:NOHC > \
events/sched/sched_stat_runtime/trigger
# sleep 10
# cat events/sched/sched_stat_runtime/hist
# event histogram
#
# trigger info: hist:keys=pid:vals=hitcount.percent,hitcount.graph:sort=pid:size=2048:nohitcount [active]
#
{ pid: 14 } hitcount (%): 6.91 hitcount: ##
{ pid: 16 } hitcount (%): 1.13 hitcount:
{ pid: 57 } hitcount (%): 6.99 hitcount: ##
{ pid: 61 } hitcount (%): 55.28 hitcount: ####################
{ pid: 67 } hitcount (%): 5.52 hitcount: ##
{ pid: 69 } hitcount (%): 20.08 hitcount: #######
{ pid: 71 } hitcount (%): 0.40 hitcount:
{ pid: 77 } hitcount (%): 0.97 hitcount:
{ pid: 78 } hitcount (%): 0.56 hitcount:
{ pid: 145 } hitcount (%): 1.13 hitcount:
{ pid: 153 } hitcount (%): 0.48 hitcount:
{ pid: 154 } hitcount (%): 0.48 hitcount:
Totals:
Hits: 1230
Entries: 12
Dropped: 0
With the NOHC (or nohitcount) option, the histogram will skip
display of raw hitcount, but it will allow to display percent
and graph of hitcount.
Trigger Result
val=runtime -> Show hitcount and runtime
val=runtime:NOHC -> Show runtime
val=hitcount:NOHC -> Error
(noval) -> show hitcount
(noval):NOHC -> Error
val=hitcount.parcent -> show hitcount and hitcount%
val=hitcount.parcent:NOHC -> show hitcount%
Thank you,
---
Masami Hiramatsu (Google) (4):
tracing: Add .percent suffix option to histogram values
tracing: Add .graph suffix option to histogram value
tracing: Add nohitcount option for suppressing display of raw hitcount
tracing: docs: Update histogram doc for .percent/.graph and 'nohitcount'
Tom Zanussi (1):
tracing: Allow multiple hitcount values in histograms
Documentation/trace/histogram.rst | 10 ++
kernel/trace/trace.c | 7 +
kernel/trace/trace_events_hist.c | 177 ++++++++++++++++++++++++++++++++-----
3 files changed, 169 insertions(+), 25 deletions(-)
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next reply other threads:[~2022-10-18 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 15:48 Masami Hiramatsu (Google) [this message]
2022-10-18 15:48 ` [PATCH v6 1/5] tracing: Allow multiple hitcount values in histograms Masami Hiramatsu (Google)
2022-10-18 15:48 ` [PATCH v6 2/5] tracing: Add .percent suffix option to histogram values Masami Hiramatsu (Google)
2022-10-18 15:48 ` [PATCH v6 3/5] tracing: Add .graph suffix option to histogram value Masami Hiramatsu (Google)
2022-10-18 15:49 ` [PATCH v6 4/5] tracing: Add nohitcount option for suppressing display of raw hitcount Masami Hiramatsu (Google)
2022-10-18 15:49 ` [PATCH v6 5/5] tracing: docs: Update histogram doc for .percent/.graph and 'nohitcount' Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166610811353.56030.10023036046735082272.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox