From: Kalle Valo <kvalo@kernel.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-wireless@vger.kernel.org
Subject: Re: wifi: airo: do not assign -1 to unsigned char
Date: Tue, 1 Nov 2022 09:15:26 +0000 (UTC) [thread overview]
Message-ID: <166729412401.15005.1682705386476857844.kvalo@kernel.org> (raw)
In-Reply-To: <20221024162843.535921-1-Jason@zx2c4.com>
"Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, we get a warning when assigning the
> unchecked output of hex_to_bin() to that unsigned char. Mark `key` as a
> `u8`, which matches the struct's type, and then check each call to
> hex_to_bin() before casting.
>
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: linux-wireless@vger.kernel.org
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Patch applied to wireless.git, thanks.
e6cb8769452e wifi: airo: do not assign -1 to unsigned char
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221024162843.535921-1-Jason@zx2c4.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-11-01 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 16:28 [PATCH] wifi: cisco: do not assign -1 to unsigned char Jason A. Donenfeld
2022-10-25 10:11 ` David Laight
2022-10-25 12:12 ` Jason A. Donenfeld
2022-11-01 9:15 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166729412401.15005.1682705386476857844.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox