Re: [PATCH 0/3] RZ/Five: Enable ADC/CANFD/I2C/OPP/Thermal Zones/TSU

Geert Uytterhoeven
2022-11-16T09:27:09Z

On Tue, Nov 15, 2022 at 7:23 PM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Tue, Nov 15, 2022 at 2:21 PM Conor Dooley <conor.dooley@microchip.com> wrote:
> > On Tue, Nov 15, 2022 at 10:51:32AM +0000, Prabhakar wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > Hi All,
> > >
> > > This patch series aims to enable support for below blocks
> > > on RZ/Five SoC/SMARC EVK:
> > > - ADC
> > > - CANFD
> > > - I2C
> > > - OPP
> > > - Thermal Zones
> > > - TSU
> > >
> > > Note, patches apply on top of [0].
> > >
> > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git/log/?h=renesas-riscv-dt-for-v6.2
> > >
> > > Cheers,
> > > Prabhakar
> > >
> > > Lad Prabhakar (3):
> > > riscv: Kconfig: Enable cpufreq kconfig menu
> > > riscv: dts: renesas: r9a07g043f/rzfive-smarc-som: Enable
> > > ADC/OPP/Thermal Zones/TSU
> > > riscv: dts: renesas: rzfive-smarc: Enable CANFD/I2C
> >
> > I know ~nothing about your SoC so idk if the values are correct, but I
> > did give it a go earlier to see if it did anything warning wise. Seeing
> > that it didn't cause any I am curious - how come these didn't land in
> > the original dts? Just waiting for driver stuff to land to support it?
> >
> I wanted bare minimal stuff in the initial patchset.
>
> > Anyway, no new warnings which is what I care about - I suppose that
> > makes it an acked-by?
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Can include that tag if you like. Either way, nice to see some of the
> > /delete-node/s etc being removed.
> >
> Thanks, Geert should pick the tag while picking the DTS/I patches.
>
> For the Kconfig patch it needs to go via the RISCV tree or can that be
> picked by Geert too with the rest of the other patches?

IMHO the Kconfig patch (or Conor's earlier version) should go through
the RISCV tree, as there is no hard dependency.

Yes, I can take it with an Acked-by, if all else fails, but the soc deadline
is near.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds