From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [RFC PATCH v2] Tracepoint: register/unregister struct tracepoint
Date: Thu, 13 Mar 2014 16:54:16 +0000 (UTC) [thread overview]
Message-ID: <1670411611.2880.1394729656679.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20140313163531.GD14899@redhat.com>
----- Original Message -----
> From: "Frank Ch. Eigler" <fche@redhat.com>
> To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> Cc: "Steven Rostedt" <rostedt@goodmis.org>, linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>, "Frederic
> Weisbecker" <fweisbec@gmail.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Johannes Berg"
> <johannes.berg@intel.com>
> Sent: Thursday, March 13, 2014 12:35:31 PM
> Subject: Re: [RFC PATCH v2] Tracepoint: register/unregister struct tracepoint
>
> Hi -
>
> On Thu, Mar 13, 2014 at 12:10:48PM -0400, Mathieu Desnoyers wrote:
>
> > [...] Moreover, tracers are responsible for unregistering the probe
> > before the module containing its associated tracepoint is unloaded.
>
> Could you spell out please how a tracer is supposed to know early
> enough that the module is going to be unloaded?
There are two ways this can be done.
One use-case is when the probe and the callsite are within the same module,
or if the module containing the probe has a symbol dependency on the callsite.
In this case the probe normally unregisters itself from a module exit function
before the module unloads.
The other use-case is if the tracer has a module coming/going notifier
tracking the module's tracepoint callsites. The going notifier should
be run before the tracepoint.c going notifier. A notifier with negative
priority should have this effect, since the tracepoint.c notifier has
priority 0.
Thoughts ?
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2014-03-13 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 16:10 [RFC PATCH v2] Tracepoint: register/unregister struct tracepoint Mathieu Desnoyers
2014-03-13 16:35 ` Frank Ch. Eigler
2014-03-13 16:54 ` Mathieu Desnoyers [this message]
2014-03-13 18:17 ` Steven Rostedt
2014-03-13 18:22 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1670411611.2880.1394729656679.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=akpm@linux-foundation.org \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox