From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, arnd@arndb.de,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH] staging: media: omap4iss: mark omap4iss_flush() static
Date: Mon, 05 Sep 2016 14:49:40 +0300 [thread overview]
Message-ID: <1671412.XD9t8jCPcC@avalon> (raw)
In-Reply-To: <1472971301-4650-1-git-send-email-baoyou.xie@linaro.org>
Hi Baoyou,
Thank you for the patch.
On Sunday 04 Sep 2016 14:41:41 Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype
> for 'omap4iss_flush' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/staging/media/omap4iss/iss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c
> b/drivers/staging/media/omap4iss/iss.c index 6ceb4eb..e27c7a9 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -61,7 +61,7 @@ static void iss_print_status(struct iss_device *iss)
> * See this link for reference:
> * http://www.mail-archive.com/linux-omap@vger.kernel.org/msg08149.html
> */
> -void omap4iss_flush(struct iss_device *iss)
> +static void omap4iss_flush(struct iss_device *iss)
> {
> iss_reg_write(iss, OMAP4_ISS_MEM_TOP, ISS_HL_REVISION, 0);
> iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_HL_REVISION);
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2016-09-05 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 6:41 [PATCH] staging: media: omap4iss: mark omap4iss_flush() static Baoyou Xie
2016-09-05 11:49 ` Arnd Bergmann
2016-09-05 11:49 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1671412.XD9t8jCPcC@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox