* [PATCH] myri10ge: Fix an error handling path in myri10ge_probe()
@ 2022-12-18 18:08 Christophe JAILLET
2022-12-19 12:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2022-12-18 18:08 UTC (permalink / raw)
To: Chris Lee, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Andrew Gallatin, Brice Goglin, Jeff Garzik
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, netdev
Some memory allocated in myri10ge_probe_slices() is not released in the
error handling path of myri10ge_probe().
Add the corresponding kfree(), as already done in the remove function.
Fixes: 0dcffac1a329 ("myri10ge: add multislices support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 8073d7a90a26..c5687d94ea88 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -3912,6 +3912,7 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
myri10ge_free_slices(mgp);
abort_with_firmware:
+ kfree(mgp->msix_vectors);
myri10ge_dummy_rdma(mgp, 0);
abort_with_ioremap:
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] myri10ge: Fix an error handling path in myri10ge_probe()
2022-12-18 18:08 [PATCH] myri10ge: Fix an error handling path in myri10ge_probe() Christophe JAILLET
@ 2022-12-19 12:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-12-19 12:40 UTC (permalink / raw)
To: Christophe JAILLET
Cc: christopher.lee, davem, edumazet, kuba, pabeni, gallatin, brice,
jgarzik, linux-kernel, kernel-janitors, netdev
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Sun, 18 Dec 2022 19:08:40 +0100 you wrote:
> Some memory allocated in myri10ge_probe_slices() is not released in the
> error handling path of myri10ge_probe().
>
> Add the corresponding kfree(), as already done in the remove function.
>
> Fixes: 0dcffac1a329 ("myri10ge: add multislices support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> [...]
Here is the summary with links:
- myri10ge: Fix an error handling path in myri10ge_probe()
https://git.kernel.org/netdev/net/c/d83b950d44d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-19 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-18 18:08 [PATCH] myri10ge: Fix an error handling path in myri10ge_probe() Christophe JAILLET
2022-12-19 12:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox