From: patchwork-bot+netdevbpf@kernel.org
To: Frederick Lawler <fred@cloudflare.com>
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
kuba@kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
zymon.heidrich@gmail.com, phil@nwl.cc, netdev@vger.kernel.org,
kernel-team@cloudflare.com, stable@vger.kernel.org,
jakub@cloudflare.com
Subject: Re: [PATCH net] net: sched: disallow noqueue for qdisc classes
Date: Wed, 11 Jan 2023 02:30:16 +0000 [thread overview]
Message-ID: <167340421666.10258.1866242868170260870.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230109163906.706000-1-fred@cloudflare.com>
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 9 Jan 2023 10:39:06 -0600 you wrote:
> While experimenting with applying noqueue to a classful queue discipline,
> we discovered a NULL pointer dereference in the __dev_queue_xmit()
> path that generates a kernel OOPS:
>
> # dev=enp0s5
> # tc qdisc replace dev $dev root handle 1: htb default 1
> # tc class add dev $dev parent 1: classid 1:1 htb rate 10mbit
> # tc qdisc add dev $dev parent 1:1 handle 10: noqueue
> # ping -I $dev -w 1 -c 1 1.1.1.1
>
> [...]
Here is the summary with links:
- [net] net: sched: disallow noqueue for qdisc classes
https://git.kernel.org/netdev/net/c/96398560f26a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-01-11 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 16:39 [PATCH net] net: sched: disallow noqueue for qdisc classes Frederick Lawler
2023-01-11 2:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167340421666.10258.1866242868170260870.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fred@cloudflare.com \
--cc=jakub@cloudflare.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phil@nwl.cc \
--cc=stable@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
--cc=zymon.heidrich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox