* [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE
@ 2023-01-10 8:04 guoren
2023-01-10 10:21 ` Alexandre Ghiti
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: guoren @ 2023-01-10 8:04 UTC (permalink / raw)
To: guoren, alexandre.ghiti, palmer; +Cc: linux-riscv, linux-kernel, Guo Ren
From: Guo Ren <guoren@linux.alibaba.com>
KERN_VIRT_SIZE is 1/4 of the entries of the page global directory,
not half.
Fixes: f7ae02333d13 ("riscv: Move KASAN mapping next to the kernel mapping")
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Cc: Alexandre Ghiti <alexandre.ghiti@canonical.com>
---
arch/riscv/include/asm/pgtable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
index 4eba9a98d0e3..2a88362dffa5 100644
--- a/arch/riscv/include/asm/pgtable.h
+++ b/arch/riscv/include/asm/pgtable.h
@@ -31,7 +31,7 @@
#define PTRS_PER_PTE (PAGE_SIZE / sizeof(pte_t))
/*
- * Half of the kernel address space (half of the entries of the page global
+ * Half of the kernel address space (1/4 of the entries of the page global
* directory) is for the direct mapping.
*/
#define KERN_VIRT_SIZE ((PTRS_PER_PGD / 2 * PGDIR_SIZE) / 2)
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE
2023-01-10 8:04 [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE guoren
@ 2023-01-10 10:21 ` Alexandre Ghiti
2023-01-25 3:48 ` Palmer Dabbelt
2023-01-25 3:50 ` patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Ghiti @ 2023-01-10 10:21 UTC (permalink / raw)
To: guoren, alexandre.ghiti, palmer; +Cc: linux-riscv, linux-kernel, Guo Ren
Hi Guo,
On 1/10/23 09:04, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> KERN_VIRT_SIZE is 1/4 of the entries of the page global directory,
> not half.
>
> Fixes: f7ae02333d13 ("riscv: Move KASAN mapping next to the kernel mapping")
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Cc: Alexandre Ghiti <alexandre.ghiti@canonical.com>
> ---
> arch/riscv/include/asm/pgtable.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> index 4eba9a98d0e3..2a88362dffa5 100644
> --- a/arch/riscv/include/asm/pgtable.h
> +++ b/arch/riscv/include/asm/pgtable.h
> @@ -31,7 +31,7 @@
> #define PTRS_PER_PTE (PAGE_SIZE / sizeof(pte_t))
>
> /*
> - * Half of the kernel address space (half of the entries of the page global
> + * Half of the kernel address space (1/4 of the entries of the page global
Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Thanks,
Alex
> * directory) is for the direct mapping.
> */
> #define KERN_VIRT_SIZE ((PTRS_PER_PGD / 2 * PGDIR_SIZE) / 2)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE
2023-01-10 8:04 [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE guoren
2023-01-10 10:21 ` Alexandre Ghiti
@ 2023-01-25 3:48 ` Palmer Dabbelt
2023-01-25 3:50 ` patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: Palmer Dabbelt @ 2023-01-25 3:48 UTC (permalink / raw)
To: guoren, alex, Palmer Dabbelt; +Cc: linux-kernel, Guo Ren, linux-riscv
On Tue, 10 Jan 2023 03:04:19 -0500, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> KERN_VIRT_SIZE is 1/4 of the entries of the page global directory,
> not half.
>
>
Applied, thanks!
[1/1] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE
https://git.kernel.org/palmer/c/6be1ff430dab
Best regards,
--
Palmer Dabbelt <palmer@rivosinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE
2023-01-10 8:04 [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE guoren
2023-01-10 10:21 ` Alexandre Ghiti
2023-01-25 3:48 ` Palmer Dabbelt
@ 2023-01-25 3:50 ` patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-riscv @ 2023-01-25 3:50 UTC (permalink / raw)
To: Guo Ren; +Cc: linux-riscv, alexandre.ghiti, palmer, linux-kernel, guoren
Hello:
This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Tue, 10 Jan 2023 03:04:19 -0500 you wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> KERN_VIRT_SIZE is 1/4 of the entries of the page global directory,
> not half.
>
> Fixes: f7ae02333d13 ("riscv: Move KASAN mapping next to the kernel mapping")
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Cc: Alexandre Ghiti <alexandre.ghiti@canonical.com>
>
> [...]
Here is the summary with links:
- riscv: pgtable: Fixup comment for KERN_VIRT_SIZE
https://git.kernel.org/riscv/c/6be1ff430dab
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-25 3:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-10 8:04 [PATCH] riscv: pgtable: Fixup comment for KERN_VIRT_SIZE guoren
2023-01-10 10:21 ` Alexandre Ghiti
2023-01-25 3:48 ` Palmer Dabbelt
2023-01-25 3:50 ` patchwork-bot+linux-riscv
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox