From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757119AbcH2LA2 (ORCPT ); Mon, 29 Aug 2016 07:00:28 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:54227 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756473AbcH2LA1 (ORCPT ); Mon, 29 Aug 2016 07:00:27 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible Date: Mon, 29 Aug 2016 12:54:55 +0200 Message-ID: <16746903.dkEEJ6ppqu@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1472318124-25541-1-git-send-email-baoyou.xie@linaro.org> References: <1472318124-25541-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:356H89VIcYR56sD8xRsaKjemF1KegdS/gS4V5Qd3MHrdeoSYLBy 04G54ddOHA1tOpLNXNYPPJD3IGYZQVoLxzS0tYWkzpNACQD9BxfWaNfgAMGWuIJmrqZReFT 65Co+HMRAhQ/yc+6IXGwlC44lphR/zlOzom+hPOTeYJuvIfWNI9pqe7o+W+6lb7AxNV9k0b bwDiWpzRZXbmQ9vg4UycA== X-UI-Out-Filterresults: notjunk:1;V01:K0:qg9f3vAXQcc=:E3+CO6yRlzXKYiWjKLILop oXI4kD13ODg/lpYpVWCDBPZHEVJVxd9QFHfhL8E391VA15yrRg1xzNakMiqoCEyZY0uSI90PI E8CR2Cjb2R+erAxHV9b2HbTUzNrcKGZFVfT4+6qke7FmXoMTCcXS7LI1jZ6OyWp6MIDhbUDiC fWsdJmQWwyrICp/mtgSuC+eKRfYDjyF3yp9FYvpzChtX8MSHOqL43M0o5AkGs16zv0+fmKm2F ID5InFz7bWHQjgy5KKe4E8v+lFzIKKFg5MUpIv7N9m5DvyozepgIIPLYzxJoLkrcvd7NOU0C5 cGeiGYmwgDWdAcPywt9vEfqzJlsCYIf/1g0DyK+lP4hgfLQpHgegmk1p0U6Uswn8fMl9aSRKA 7Cw/7jWU20n6y1CL3j+GX/vojSsKtOOS7eA5K/7G6rsciOtqRFhKO30iRw9fn/T8wLAw0G1pb V78xPcffcEVNbboCS3uzViigMUYE1oxduV+O1AqswyTp1WgH2XGc7NXhu+kLKbZFuHPI7OZpL lbK4RsdZg4VnbLGVNgyHAjji9hK8sIrC0V3L19ah7e/dU5jYcHm3M+SD/rZZpvLYrUpqOM6pc jvoinRhX0rX/epdpgbwQC2k/Eadf4eLcF9+vax8KbyR/q1q0SioNf1GVaSqajsviN08YbTN1I 5PZ5ZXB6Nx0d8Z3IiU3wUjwAgDxF7TuCnZPtgsHLKmSpP/1BF4pGr2cCZA9WQweEoPGLAeQIn vy099OGWzHhqKn6c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, August 28, 2016 1:15:24 AM CEST Baoyou Xie wrote: > We get 2 warnings when biuld kernel with W=1: > drivers/mailbox/bcm-pdc-mailbox.c:472:6: warning: no previous prototype for 'pdc_setup_debugfs' [-Wmissing-prototypes] > drivers/mailbox/bcm-pdc-mailbox.c:488:6: warning: no previous prototype for 'pdc_free_debugfs' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann