From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755840AbdKCQOo convert rfc822-to-8bit (ORCPT ); Fri, 3 Nov 2017 12:14:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59008 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbdKCQOn (ORCPT ); Fri, 3 Nov 2017 12:14:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 43427D9635 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mlureau@redhat.com Date: Fri, 3 Nov 2017 12:14:43 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, aarcange@redhat.com, hughd@google.com, nyc@holomorphy.com Message-ID: <1675520780.35881890.1509725683143.JavaMail.zimbra@redhat.com> In-Reply-To: <30bfff65-4cb9-a6b6-ab31-73d767a4b8ae@oracle.com> References: <20171031184052.25253-1-marcandre.lureau@redhat.com> <20171031184052.25253-4-marcandre.lureau@redhat.com> <30bfff65-4cb9-a6b6-ab31-73d767a4b8ae@oracle.com> Subject: Re: [PATCH 3/6] hugetlb: expose hugetlbfs_inode_info in header MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.36.112.63, 10.4.195.4] Thread-Topic: hugetlb: expose hugetlbfs_inode_info in header Thread-Index: Ey+RHBMPWW9+WO0ZI2i5uLeC3kkqzw== X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 03 Nov 2017 16:14:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi ----- Original Message ----- > On 10/31/2017 11:40 AM, Marc-André Lureau wrote: > > The following patch is going to access hugetlbfs_inode_info field from > > mm/shmem.c. > > The code looks fine. However, I would prefer something different for the > commit message. Perhaps something like: > > hugetlbfs inode information will need to be accessed by code in mm/shmem.c > for file sealing operations. Move inode information definition from .c > file to header for needed access. Ok, Does the patch get your Reviewed-by tag with that change? thanks