From: patchwork-bot+netdevbpf@kernel.org
To: Pietro Borrello <borrello@diag.uniroma1.it>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, lorenzo@google.com,
stephen@networkplumber.org, c.giuffrida@vu.nl, h.j.bos@vu.nl,
jkl820.git@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/3] tuntap: correctly initialize socket uid
Date: Mon, 06 Feb 2023 10:20:16 +0000 [thread overview]
Message-ID: <167567881680.5476.3963142147251645490.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230131-tuntap-sk-uid-v3-0-81188b909685@diag.uniroma1.it>
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Sat, 04 Feb 2023 17:39:19 +0000 you wrote:
> sock_init_data() assumes that the `struct socket` passed in input is
> contained in a `struct socket_alloc` allocated with sock_alloc().
> However, tap_open() and tun_chr_open() pass a `struct socket` embedded
> in a `struct tap_queue` and `struct tun_file` respectively, both
> allocated with sk_alloc().
> This causes a type confusion when issuing a container_of() with
> SOCK_INODE() in sock_init_data() which results in assigning a wrong
> sk_uid to the `struct sock` in input.
>
> [...]
Here is the summary with links:
- [net-next,v3,1/3] net: add sock_init_data_uid()
https://git.kernel.org/netdev/net-next/c/584f3742890e
- [net-next,v3,2/3] tun: tun_chr_open(): correctly initialize socket uid
https://git.kernel.org/netdev/net-next/c/a096ccca6e50
- [net-next,v3,3/3] tap: tap_open(): correctly initialize socket uid
https://git.kernel.org/netdev/net-next/c/66b2c338adce
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-02-06 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 17:39 [PATCH net-next v3 0/3] tuntap: correctly initialize socket uid Pietro Borrello
2023-02-04 17:39 ` [PATCH net-next v3 1/3] net: add sock_init_data_uid() Pietro Borrello
2023-02-06 8:28 ` Eric Dumazet
2023-02-04 17:39 ` [PATCH net-next v3 2/3] tun: tun_chr_open(): correctly initialize socket uid Pietro Borrello
2023-02-06 8:29 ` Eric Dumazet
2023-02-04 17:39 ` [PATCH net-next v3 3/3] tap: tap_open(): " Pietro Borrello
2023-02-06 8:30 ` Eric Dumazet
2023-02-06 10:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167567881680.5476.3963142147251645490.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=borrello@diag.uniroma1.it \
--cc=c.giuffrida@vu.nl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=h.j.bos@vu.nl \
--cc=jkl820.git@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox