From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752234AbbIWHvO (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Sep 2015 03:51:14 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:53381 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751921AbbIWHvM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Sep 2015 03:51:12 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: David Daney <ddaney.cavm@gmail.com>, linux-kernel@vger.kernel.org,
        Will Deacon <will.deacon@arm.com>, Marc Zyngier <marc.zyngier@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges.
Date: Wed, 23 Sep 2015 09:51 +0200
Message-ID: <1675889.xYIhzenZEC@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1442966996-13419-1-git-send-email-ddaney.cavm@gmail.com>
References: <1442966996-13419-1-git-send-email-ddaney.cavm@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:fN6mXSdd2cZGfc0pq4q43g+R4fr6LTxaxNoTfyR1hjGCyDJP31f
 yZsdXvR+nJNIQQLQsggZiFaxPwLjefnkkqIy4/IfVERvKPrCtLSIus3SDkIVGmHUV0cQ+gA
 eYjQ0ELy2pI0l/UM64xSPEibCHlbFS19n67GkH3tLIQCAqTs+kUPe5zHzpzMAeSmsbAGJ/M
 RpSyqQC1IQrclCNqp924A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:W2GHOCiNy8w=:6EpwZuAnak/rhe68RcngYT
 RM0raWVbvnSGuswAzxYzm4Eur2y5N9pmGOtoQk2lWRAnUJfF2TKoqqo5+8/Vd4dAxPJYfblak
 fl0NzjnXQAw1ooaI9Cy9dAZGAqvoSwaxejuaOSMBHqFt1d3+vurpbQOLlCuAWqOE2BwV9SjeI
 dyZc5WHO9iXV5sjaWr6/UbsE7nsnAj9kvktHtUsJVrQd+KDAeiVB6Qy9mtWKw6dqy0+1i7nbD
 NZFTmNXAzZPk8RtNK7aRxCE9JmU3s9s+0bdURscY1sVqmpR3K3opYNDgFWHimlqn5H2wLa3gf
 XNLsVZDisr/NjLy0Wa3WFYeSWP8gLepozU8Gy06Ro47Yn2ySvIXQVxENMBpFmjObk903wkcGw
 kW9Fzu9pzhYyhCUm2WBMBTOvTTi8ge/Ll7F5kR42bNpKOH29G0A96cLU2xyVou73JEzrIUJsB
 TGhIOs6H+s82P0w/glDC+8yJ+EPFYI6JYxKi9LImD2hNS/34V3T9GbYEXIsmJ7+NxtflusqQN
 HotbydQ8Ihe2PA47xGkckX1zOlTIT3ADKxoxSaeu7NOEMlc+EcpP8L59qVhpuo9ShuMvbJh/A
 mb8gr2QozVRr3ABtPAK+2tGEYbz6DiEcMSCfxtSY04if23hZu6dkZ47w0rec5+wbJD/PjDLro
 KRxLpBnAi7Gf3jJ13myvGF9yoAVQrxhRjMr2Zy4Q0SWhrbfnxlhw9U1O8ysA4AOBMOm+61Qnx
 8BWRn8LOxHwHHo+t
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 22 September 2015 17:09:56 David Daney wrote:
> From: David Daney <david.daney@cavium.com>
> 
> The Cavium ThunderX SoC needs a PCI quirk for its on-chip bridges.
> Since it is arm64, create a new quirks.c file there to contain arm64
> related quirks.  Add the ThunderX bridge quirk, gated by a new config
> variable, so that it can be disabled for kernels that aren't expected
> to be used on ThunderX.
> 
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
>  arch/arm64/Kconfig         | 11 +++++++++++
>  arch/arm64/kernel/Makefile |  2 +-
>  arch/arm64/kernel/quirks.c | 36 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 48 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm64/kernel/quirks.c
> 

Looks reasonable to me. Just one question: Is the same bridge used
on MIPS machines? If so, maybe it should be moved to drivers/pci/quirks.c
instead for better reuse.

	Arnd