* [PATCH 1/1] net: stmmac: Restrict warning on disabling DMA store and fwd mode
@ 2023-02-10 20:21 Cristian Ciocaltea
2023-02-14 8:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Cristian Ciocaltea @ 2023-02-10 20:21 UTC (permalink / raw)
To: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin,
Sonic Zhang
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel, kernel
When setting 'snps,force_thresh_dma_mode' DT property, the following
warning is always emitted, regardless the status of force_sf_dma_mode:
dwmac-starfive 10020000.ethernet: force_sf_dma_mode is ignored if force_thresh_dma_mode is set.
Do not print the rather misleading message when DMA store and forward
mode is already disabled.
Fixes: e2a240c7d3bc ("driver:net:stmmac: Disable DMA store and forward mode if platform data force_thresh_dma_mode is set.")
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index eb6d9cd8e93f..0046a4ee6e64 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -559,7 +559,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
dma_cfg->mixed_burst = of_property_read_bool(np, "snps,mixed-burst");
plat->force_thresh_dma_mode = of_property_read_bool(np, "snps,force_thresh_dma_mode");
- if (plat->force_thresh_dma_mode) {
+ if (plat->force_thresh_dma_mode && plat->force_sf_dma_mode) {
plat->force_sf_dma_mode = 0;
dev_warn(&pdev->dev,
"force_sf_dma_mode is ignored if force_thresh_dma_mode is set.\n");
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] net: stmmac: Restrict warning on disabling DMA store and fwd mode
2023-02-10 20:21 [PATCH 1/1] net: stmmac: Restrict warning on disabling DMA store and fwd mode Cristian Ciocaltea
@ 2023-02-14 8:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-14 8:20 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: peppe.cavallaro, alexandre.torgue, joabreu, davem, edumazet, kuba,
pabeni, mcoquelin.stm32, sonic.zhang, netdev, linux-stm32,
linux-arm-kernel, linux-kernel, kernel
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 10 Feb 2023 22:21:26 +0200 you wrote:
> When setting 'snps,force_thresh_dma_mode' DT property, the following
> warning is always emitted, regardless the status of force_sf_dma_mode:
>
> dwmac-starfive 10020000.ethernet: force_sf_dma_mode is ignored if force_thresh_dma_mode is set.
>
> Do not print the rather misleading message when DMA store and forward
> mode is already disabled.
>
> [...]
Here is the summary with links:
- [1/1] net: stmmac: Restrict warning on disabling DMA store and fwd mode
https://git.kernel.org/netdev/net/c/05d7623a892a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-14 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-10 20:21 [PATCH 1/1] net: stmmac: Restrict warning on disabling DMA store and fwd mode Cristian Ciocaltea
2023-02-14 8:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox