* [PATCH net-next v1 1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error
@ 2023-02-15 5:04 Oleksij Rempel
2023-02-15 17:45 ` Andrew Lunn
2023-02-16 5:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Oleksij Rempel @ 2023-02-15 5:04 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: Oleksij Rempel, kernel test robot, Dan Carpenter, kernel,
linux-kernel, netdev
Fix warning:
drivers/net/phy/phy-c45.c:712 genphy_c45_write_eee_adv() error: uninitialized symbol 'changed'
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/202302150232.q6idsV8s-lkp@intel.com/
Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/phy/phy-c45.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
index ef36582adbeb..f9b128cecc3f 100644
--- a/drivers/net/phy/phy-c45.c
+++ b/drivers/net/phy/phy-c45.c
@@ -256,7 +256,7 @@ static int genphy_c45_baset1_an_config_aneg(struct phy_device *phydev)
*/
int genphy_c45_an_config_aneg(struct phy_device *phydev)
{
- int changed, ret;
+ int changed = 0, ret;
u32 adv;
linkmode_and(phydev->advertising, phydev->advertising,
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next v1 1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error
2023-02-15 5:04 [PATCH net-next v1 1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error Oleksij Rempel
@ 2023-02-15 17:45 ` Andrew Lunn
2023-02-16 5:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2023-02-15 17:45 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Heiner Kallweit, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, kernel test robot, Dan Carpenter, kernel,
linux-kernel, netdev
On Wed, Feb 15, 2023 at 06:04:53AM +0100, Oleksij Rempel wrote:
> Fix warning:
> drivers/net/phy/phy-c45.c:712 genphy_c45_write_eee_adv() error: uninitialized symbol 'changed'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/r/202302150232.q6idsV8s-lkp@intel.com/
> Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next v1 1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error
2023-02-15 5:04 [PATCH net-next v1 1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error Oleksij Rempel
2023-02-15 17:45 ` Andrew Lunn
@ 2023-02-16 5:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-16 5:30 UTC (permalink / raw)
To: Oleksij Rempel
Cc: andrew, hkallweit1, davem, edumazet, kuba, pabeni, lkp, error27,
kernel, linux-kernel, netdev
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 15 Feb 2023 06:04:53 +0100 you wrote:
> Fix warning:
> drivers/net/phy/phy-c45.c:712 genphy_c45_write_eee_adv() error: uninitialized symbol 'changed'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/r/202302150232.q6idsV8s-lkp@intel.com/
> Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> [...]
Here is the summary with links:
- [net-next,v1,1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error
https://git.kernel.org/netdev/net-next/c/c24a34f5a3d7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-16 5:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-15 5:04 [PATCH net-next v1 1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error Oleksij Rempel
2023-02-15 17:45 ` Andrew Lunn
2023-02-16 5:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox