From: Casey Schaufler <casey@schaufler-ca.com>
To: Jan Engelhardt <jengelh@computergmbh.de>,
Thomas Bleher <ThomasBleher@gmx.de>
Cc: Casey Schaufler <casey@schaufler-ca.com>,
torvalds@osdl.org, akpm@osdl.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Version2 Smack: Simplified Mandatory Access Control Kernel
Date: Thu, 30 Aug 2007 14:51:44 -0700 (PDT) [thread overview]
Message-ID: <167655.10399.qm@web36602.mail.mud.yahoo.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0708302059270.24730@fbirervta.pbzchgretzou.qr>
--- Jan Engelhardt <jengelh@computergmbh.de> wrote:
>
> On Aug 27 2007 23:59, Thomas Bleher wrote:
>
> >> + for (cp = data - 1; cp != NULL; cp = strchr(cp + 1, '\n')) {
> >> + if (*++cp == '\0')
> >> + break;
> >> + if (sscanf(cp, "%14s %30s\n", name, target) != 2) {
> >> + printk("%s:%d bad scan\n",
> >> + __func__, __LINE__);
> >
> >Leftover debugging printk? Otherwise, a level would be nice.
>
> Or even pr_debug.
>
> (pr_debug("%s...
I'm taking out the printk.
> >> + static struct tree_descr smack_files[] = {
>
> Hey, can we make this const, if it does not change at runtime?
simple_fill_super() is unhappy with a const.
Casey Schaufler
casey@schaufler-ca.com
prev parent reply other threads:[~2007-08-30 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-26 4:18 [PATCH] Version2 Smack: Simplified Mandatory Access Control Kernel Casey Schaufler
2007-08-27 21:59 ` Thomas Bleher
2007-08-28 18:59 ` Casey Schaufler
2007-08-30 19:00 ` Jan Engelhardt
2007-08-30 21:51 ` Casey Schaufler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167655.10399.qm@web36602.mail.mud.yahoo.com \
--to=casey@schaufler-ca.com \
--cc=ThomasBleher@gmx.de \
--cc=akpm@osdl.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox