Re: [PATCH v3 1/5] x86/init: Make get/set_rtc_noop() public

Saurabh Singh Sengar
2023-03-27T04:47:43Z

On Sun, Mar 26, 2023 at 03:03:17PM +0000, Michael Kelley (LINUX) wrote:
> From: Saurabh Sengar <ssengar@linux.microsoft.com> Sent: Monday, March 20, 2023 3:04 AM
> >
> > Make get/set_rtc_noop() to be public so that they can be used
> > in other modules as well.
> >
> > Co-developed-by: Tianyu Lan <tiala@microsoft.com>
> > Signed-off-by: Tianyu Lan <tiala@microsoft.com>
> > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> > Reviewed-by: Wei Liu <wei.liu@kernel.org>
> > ---
> > arch/x86/include/asm/x86_init.h | 2 ++
> > arch/x86/kernel/x86_init.c | 4 ++--
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h
> > index c1c8c581759d..d8fb3a1639e9 100644
> > --- a/arch/x86/include/asm/x86_init.h
> > +++ b/arch/x86/include/asm/x86_init.h
> > @@ -326,5 +326,7 @@ extern void x86_init_uint_noop(unsigned int unused);
> > extern bool bool_x86_init_noop(void);
> > extern void x86_op_int_noop(int cpu);
> > extern bool x86_pnpbios_disabled(void);
> > +extern int set_rtc_noop(const struct timespec64 *now);
> > +extern void get_rtc_noop(struct timespec64 *now);
> >
> > #endif
> > diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c
> > index ef80d361b463..d93aeffec19b 100644
> > --- a/arch/x86/kernel/x86_init.c
> > +++ b/arch/x86/kernel/x86_init.c
> > @@ -33,8 +33,8 @@ static int __init iommu_init_noop(void) { return 0; }
> > static void iommu_shutdown_noop(void) { }
> > bool __init bool_x86_init_noop(void) { return false; }
> > void x86_op_int_noop(int cpu) { }
> > -static __init int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; }
> > -static __init void get_rtc_noop(struct timespec64 *now) { }
> > +int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; }
> > +void get_rtc_noop(struct timespec64 *now) { }
> >
> > static __initconst const struct of_device_id of_cmos_match[] = {
> > { .compatible = "motorola,mc146818" },
> > --
> > 2.34.1
>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

Hi x86 maintainers,

If there is no concern, can you please ack this patch.

Regards,
Saurabh