From: David Howells <dhowells@cambridge.redhat.com>
To: afranck@gmx.de
Cc: David Howells <dhowells@cambridge.redhat.com>,
Linus Torvalds <torvalds@transmeta.com>,
Andrew Morton <andrewm@uow.edu.au>, Ben LaHaise <bcrl@redhat.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2nd try: i386 rw_semaphores fix
Date: Wed, 11 Apr 2001 15:17:19 +0100 [thread overview]
Message-ID: <16795.986998639@warthog.cambridge.redhat.com> (raw)
In-Reply-To: Your message of "Wed, 11 Apr 2001 15:40:21 +0200." <3AD45EC5.81EB82AD@akustik.rwth-aachen.de>
> I'd like you to look over it. It seems newer GCC's (snapshots and the
> upcoming 3.0) will be more strict when modifying some values through
> assembler-passed pointers - in this case, the passed semaphore structure got
> freed too early, causing massive stack corruption on early bootup.
>
> The solution was to directly mention the modified element (in this case,
> sem->count) with a "=m" qualifier, which told GCC that the contents of the
> semaphore structure are still really needed. It does not seem to have any
> bad side effects on older GCC, but lets the code work on people trying to
> use the newer snapshots.
I've just consulted with one of the gcc people we have here, and he says that
the '"memory"' constraint should do the trick.
Do I take it that that is actually insufficient?
David
next parent reply other threads:[~2001-04-11 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3AD45EC5.81EB82AD@akustik.rwth-aachen.de>
2001-04-11 14:17 ` David Howells [this message]
2001-04-11 14:32 ` [PATCH] 2nd try: i386 rw_semaphores fix Andreas Franck
2001-04-11 14:43 ` David Howells
2001-04-11 15:00 ` Andreas Franck
2001-04-11 15:14 ` Bernd Schmidt
2001-04-11 18:27 ` Linus Torvalds
2001-04-12 8:38 ` Jamie Lokier
2001-04-10 19:42 [PATCH] " Linus Torvalds
2001-04-11 12:57 ` [PATCH] 2nd try: " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16795.986998639@warthog.cambridge.redhat.com \
--to=dhowells@cambridge.redhat.com \
--cc=afranck@gmx.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrewm@uow.edu.au \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox