[PATCH] ptp_qoriq: fix memory leak in probe()

[PATCH] ptp_qoriq: fix memory leak in probe()

[SongJingyi]

Smatch complains that:
drivers/ptp/ptp_qoriq.c ptp_qoriq_probe()
warn: 'base' from ioremap() not released.

Fix this by revising the parameter from 'ptp_qoriq->base' to 'base'.
This is only a bug if ptp_qoriq_init() returns on the
first -ENODEV error path.
For other error paths ptp_qoriq->base and base are the same.
And this change makes the code more readable.

Fixes: 7f4399ba405b ("ptp_qoriq: fix NULL access if ptp dt node missing")
Signed-off-by: SongJingyi <u201912584@hust.edu.cn>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
---
 drivers/ptp/ptp_qoriq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ptp/ptp_qoriq.c b/drivers/ptp/ptp_qoriq.c
index 61530167efe4..350154e4c2b5 100644
--- a/drivers/ptp/ptp_qoriq.c
+++ b/drivers/ptp/ptp_qoriq.c
@@ -637,7 +637,7 @@ static int ptp_qoriq_probe(struct platform_device *dev)
 	return 0;
 
 no_clock:
-	iounmap(ptp_qoriq->base);
+	iounmap(base);
 no_ioremap:
 	release_resource(ptp_qoriq->rsrc);
 no_resource:
-- 
2.34.1

Re: [PATCH] ptp_qoriq: fix memory leak in probe()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 24 Mar 2023 11:14:06 +0800 you wrote:
> Smatch complains that:
> drivers/ptp/ptp_qoriq.c ptp_qoriq_probe()
> warn: 'base' from ioremap() not released.
> 
> Fix this by revising the parameter from 'ptp_qoriq->base' to 'base'.
> This is only a bug if ptp_qoriq_init() returns on the
> first -ENODEV error path.
> For other error paths ptp_qoriq->base and base are the same.
> And this change makes the code more readable.
> 
> [...]

Here is the summary with links:
  - ptp_qoriq: fix memory leak in probe()
    https://git.kernel.org/netdev/net/c/f33642224e38

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html