From: patchwork-bot+netdevbpf@kernel.org
To: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
Cc: stefanha@redhat.com, sgarzare@redhat.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
bobby.eshleman@bytedance.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@sberdevices.ru, oxffffaa@gmail.com,
avkrasnov@sberdevices.ru
Subject: Re: [PATCH net v2 0/3] fix header length on skb merging
Date: Thu, 30 Mar 2023 09:10:18 +0000 [thread overview]
Message-ID: <168016741871.21198.8299198857300036519.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <0683cc6e-5130-484c-1105-ef2eb792d355@sberdevices.ru>
Hello:
This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 28 Mar 2023 14:30:10 +0300 you wrote:
> Hello,
>
> this patchset fixes appending newly arrived skbuff to the last skbuff of
> the socket's queue during rx path. Problem fires when we are trying to
> append data to skbuff which was already processed in dequeue callback
> at least once. Dequeue callback calls function 'skb_pull()' which changes
> 'skb->len'. In current implementation 'skb->len' is used to update length
> in header of last skbuff after new data was copied to it. This is bug,
> because value in header is used to calculate 'rx_bytes'/'fwd_cnt' and
> thus must be constant during skbuff lifetime. Here is example, we have
> two skbuffs: skb0 with length 10 and skb1 with length 4.
>
> [...]
Here is the summary with links:
- [net,v2,1/3] virtio/vsock: fix header length on skb merging
https://git.kernel.org/netdev/net/c/f7154d967bc4
- [net,v2,2/3] virtio/vsock: WARN_ONCE() for invalid state of socket
https://git.kernel.org/netdev/net/c/b8d2f61fdf2a
- [net,v2,3/3] test/vsock: new skbuff appending test
https://git.kernel.org/netdev/net/c/25209a3209ec
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-03-30 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 11:30 [PATCH net v2 0/3] fix header length on skb merging Arseniy Krasnov
2023-03-28 11:31 ` [PATCH net v2 1/3] virtio/vsock: " Arseniy Krasnov
2023-03-28 11:32 ` [PATCH net v2 2/3] virtio/vsock: WARN_ONCE() for invalid state of socket Arseniy Krasnov
2023-03-28 11:33 ` [PATCH net v2 3/3] test/vsock: new skbuff appending test Arseniy Krasnov
2023-03-30 9:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168016741871.21198.8299198857300036519.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=AVKrasnov@sberdevices.ru \
--cc=bobby.eshleman@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@sberdevices.ru \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oxffffaa@gmail.com \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox