From: David Howells <dhowells@redhat.com>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Michael Kerrisk <mtk.manpages@gmail.com>,
Andreas Dilger <adilger@dilger.ca>,
Florian Weimer <fw@deneb.enyo.de>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH 3/3] statx: add STATX_ATTRIBUTES flag
Date: Thu, 18 Oct 2018 16:22:35 +0100 [thread overview]
Message-ID: <1684.1539876155@warthog.procyon.org.uk> (raw)
In-Reply-To: <20181018131125.6303-3-mszeredi@redhat.com>
Miklos Szeredi <mszeredi@redhat.com> wrote:
> + /* Having anything in attributes_mask means attributes are valid. */
> + if (tmp.stx_attributes_mask)
> + tmp.stx_mask |= STATX_ATTRIBUTES;
That would be superfluous, since userspace can make this check too.
Note that fsinfo() might inform you better - if and when it arrives.
David
next prev parent reply other threads:[~2018-10-18 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 13:11 [PATCH 1/3] orangefs: fix request_mask misuse Miklos Szeredi
2018-10-18 13:11 ` [PATCH 2/3] uapi: get rid of STATX_ALL Miklos Szeredi
2018-10-18 13:15 ` Florian Weimer
2018-10-18 14:32 ` Miklos Szeredi
2018-10-18 14:34 ` Miklos Szeredi
2018-10-19 1:45 ` Andreas Dilger
2018-10-18 14:51 ` Amir Goldstein
2018-10-18 16:11 ` Florian Weimer
2018-10-18 15:16 ` David Howells
2018-10-19 2:25 ` Andreas Dilger
2018-10-18 13:11 ` [PATCH 3/3] statx: add STATX_ATTRIBUTES flag Miklos Szeredi
2018-10-18 15:22 ` David Howells [this message]
2018-10-19 1:48 ` Andreas Dilger
2018-10-18 21:45 ` [PATCH 1/3] orangefs: fix request_mask misuse martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1684.1539876155@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=adilger@dilger.ca \
--cc=amir73il@gmail.com \
--cc=fw@deneb.enyo.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox