Re: [PATCH net-next 2/5] net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum

Vladimir Oltean
2023-05-31T17:10:51Z

On Wed, May 31, 2023 at 07:08:10PM +0200, Simon Horman wrote:
> > --- a/drivers/net/dsa/ocelot/felix_vsc9959.c
> > +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
>
> ...
>
> > @@ -1423,6 +1423,8 @@ static int vsc9959_qos_port_tas_set(struct ocelot *ocelot, int port,
> >
> > mutex_unlock(&ocelot->tas_lock);
> > return 0;
> > + } else if (taprio->cmd != TAPRIO_CMD_REPLACE) {
>
> Hi Vladimir,
>
> Do you need to 'mutex_unlock(&ocelot->tas_lock)' here?

Yup. Nice catch, thanks. I reviewed this a couple of times myself but I
missed it. I'll send a fixup patch later today, hopefully.

> > + return -EOPNOTSUPP;
> > }
> >
> > ret = ocelot_port_mqprio(ocelot, port, &taprio->mqprio);
>
> ...