Re: [PATCH net v2] net: ipa: Use the correct value for IPA_STATUS_SIZE

Alex Elder
2023-05-30T23:44:02Z

On 5/30/23 6:25 PM, Bert Karwatzki wrote:
> From 2e5e4c07606a100fd4af0f08e4cd158f88071a3a Mon Sep 17 00:00:00 2001
> From: Bert Karwatzki <spasswolf@web.de>
> To: davem@davemloft.net
> To: edumazet@google.com
> To: kuba@kernel.org
> To: pabeni@redhat.com
> Cc: elder@kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Date: Wed, 31 May 2023 00:16:33 +0200
> Subject: [PATCH net v2] net: ipa: Use correct value for IPA_STATUS_SIZE
>
> IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement
> for the size of the removed struct ipa_status which had size
> sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

If the network maintainers can deal with your patch, I'm
OK with it. David et al if you want something else, please
say so.

Reviewed-by: Alex Elder <elder@linaro.org>

> Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")
> Signed-off-by: Bert Karwatzki <spasswolf@web.de>
> ---
> drivers/net/ipa/ipa_endpoint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
> index 2ee80ed140b7..afa1d56d9095 100644
> --- a/drivers/net/ipa/ipa_endpoint.c
> +++ b/drivers/net/ipa/ipa_endpoint.c
> @@ -119,7 +119,7 @@ enum ipa_status_field_id {
> };
>
> /* Size in bytes of an IPA packet status structure */
> -#define IPA_STATUS_SIZE sizeof(__le32[4])
> +#define IPA_STATUS_SIZE sizeof(__le32[8])
>
> /* IPA status structure decoder; looks up field values for a structure */
> static u32 ipa_status_extract(struct ipa *ipa, const void *data,