* [PATCH net v2] neighbour: fix unaligned access to pneigh_entry [not found] <CANn89iKRX2QTgS44Ky6Jua-+UNrFY3E7RCT_7OfG=GnFvAzdFQ@mail.gmail.com> @ 2023-06-01 1:54 ` Qingfang DENG 2023-06-02 4:50 ` patchwork-bot+netdevbpf 0 siblings, 1 reply; 2+ messages in thread From: Qingfang DENG @ 2023-06-01 1:54 UTC (permalink / raw) To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, YOSHIFUJI Hideaki, Masahide NAKAMURA, Ville Nuorvala, netdev, linux-kernel Cc: Qingfang DENG From: Qingfang DENG <qingfang.deng@siflower.com.cn> After the blamed commit, the member key is longer 4-byte aligned. On platforms that do not support unaligned access, e.g., MIPS32R2 with unaligned_action set to 1, this will trigger a crash when accessing an IPv6 pneigh_entry, as the key is cast to an in6_addr pointer. Change the type of the key to u32 to make it aligned. Fixes: 62dd93181aaa ("[IPV6] NDISC: Set per-entry is_router flag in Proxy NA.") Signed-off-by: Qingfang DENG <qingfang.deng@siflower.com.cn> --- v2: remove the ifdef, and use u32 type include/net/neighbour.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/neighbour.h b/include/net/neighbour.h index 3fa5774bddac..f6a8ecc6b1fa 100644 --- a/include/net/neighbour.h +++ b/include/net/neighbour.h @@ -180,7 +180,7 @@ struct pneigh_entry { netdevice_tracker dev_tracker; u32 flags; u8 protocol; - u8 key[]; + u32 key[]; }; /* -- 2.34.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v2] neighbour: fix unaligned access to pneigh_entry 2023-06-01 1:54 ` [PATCH net v2] neighbour: fix unaligned access to pneigh_entry Qingfang DENG @ 2023-06-02 4:50 ` patchwork-bot+netdevbpf 0 siblings, 0 replies; 2+ messages in thread From: patchwork-bot+netdevbpf @ 2023-06-02 4:50 UTC (permalink / raw) To: Qingfang DENG Cc: davem, edumazet, kuba, pabeni, yoshfuji, nakam, vnuorval, netdev, linux-kernel, qingfang.deng Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 1 Jun 2023 09:54:32 +0800 you wrote: > From: Qingfang DENG <qingfang.deng@siflower.com.cn> > > After the blamed commit, the member key is longer 4-byte aligned. On > platforms that do not support unaligned access, e.g., MIPS32R2 with > unaligned_action set to 1, this will trigger a crash when accessing > an IPv6 pneigh_entry, as the key is cast to an in6_addr pointer. > > [...] Here is the summary with links: - [net,v2] neighbour: fix unaligned access to pneigh_entry https://git.kernel.org/netdev/net/c/ed779fe4c9b5 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-02 4:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CANn89iKRX2QTgS44Ky6Jua-+UNrFY3E7RCT_7OfG=GnFvAzdFQ@mail.gmail.com>
2023-06-01 1:54 ` [PATCH net v2] neighbour: fix unaligned access to pneigh_entry Qingfang DENG
2023-06-02 4:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox