From: patchwork-bot+netdevbpf@kernel.org
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: mptcp@lists.linux.dev, martineau@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
shuah@kernel.org, fw@strlen.de, dcaratti@redhat.com,
cpaasch@apple.com, geliangtang@gmail.com, geliang.tang@suse.com,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net 01/17] selftests: mptcp: lib: skip if not below kernel version
Date: Tue, 13 Jun 2023 00:00:23 +0000 [thread overview]
Message-ID: <168661442392.10094.4616497599019441750.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230609-upstream-net-20230610-mptcp-selftests-support-old-kernels-part-3-v1-1-2896fe2ee8a3@tessares.net>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 10 Jun 2023 18:11:36 +0200 you wrote:
> Selftests are supposed to run on any kernels, including the old ones not
> supporting all MPTCP features.
>
> A new function is now available to easily detect if a feature is
> missing by looking at the kernel version. That's clearly not ideal and
> this kind of check should be avoided as soon as possible. But sometimes,
> there are no external sign that a "feature" is available or not:
> internal behaviours can change without modifying the uAPI and these
> selftests are verifying the internal behaviours. Sometimes, the only
> (easy) way to verify if the feature is present is to run the test but
> then the validation cannot determine if there is a failure with the
> feature or if the feature is missing. Then it looks better to check the
> kernel version instead of having tests that can never fail. In any case,
> we need a solution not to have a whole selftest being marked as failed
> just because one sub-test has failed.
>
> [...]
Here is the summary with links:
- [net,01/17] selftests: mptcp: lib: skip if not below kernel version
https://git.kernel.org/netdev/net/c/b1a6a38ab8a6
- [net,02/17] selftests: mptcp: join: use 'iptables-legacy' if available
https://git.kernel.org/netdev/net/c/0c4cd3f86a40
- [net,03/17] selftests: mptcp: join: helpers to skip tests
https://git.kernel.org/netdev/net/c/cdb50525345c
- [net,04/17] selftests: mptcp: join: skip check if MIB counter not supported
(no matching commit)
- [net,05/17] selftests: mptcp: join: skip test if iptables/tc cmds fail
https://git.kernel.org/netdev/net/c/4a0b866a3f7d
- [net,06/17] selftests: mptcp: join: support local endpoint being tracked or not
https://git.kernel.org/netdev/net/c/d4c81bbb8600
- [net,07/17] selftests: mptcp: join: skip Fastclose tests if not supported
https://git.kernel.org/netdev/net/c/ae947bb2c253
- [net,08/17] selftests: mptcp: join: support RM_ADDR for used endpoints or not
https://git.kernel.org/netdev/net/c/425ba803124b
- [net,09/17] selftests: mptcp: join: skip implicit tests if not supported
https://git.kernel.org/netdev/net/c/36c4127ae8dd
- [net,10/17] selftests: mptcp: join: skip backup if set flag on ID not supported
https://git.kernel.org/netdev/net/c/07216a3c5d92
- [net,11/17] selftests: mptcp: join: skip fullmesh flag tests if not supported
https://git.kernel.org/netdev/net/c/9db34c4294af
- [net,12/17] selftests: mptcp: join: skip userspace PM tests if not supported
https://git.kernel.org/netdev/net/c/f2b492b04a16
- [net,13/17] selftests: mptcp: join: skip fail tests if not supported
https://git.kernel.org/netdev/net/c/ff8897b51894
- [net,14/17] selftests: mptcp: join: skip MPC backups tests if not supported
https://git.kernel.org/netdev/net/c/632978f0a961
- [net,15/17] selftests: mptcp: join: skip PM listener tests if not supported
https://git.kernel.org/netdev/net/c/0471bb479af0
- [net,16/17] selftests: mptcp: join: uniform listener tests
https://git.kernel.org/netdev/net/c/96b84195df61
- [net,17/17] selftests: mptcp: join: skip mixed tests if not supported
https://git.kernel.org/netdev/net/c/6673851be0fc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2023-06-13 0:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 16:11 [PATCH net 00/17] selftests: mptcp: skip tests not supported by old kernels (part 3) Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 01/17] selftests: mptcp: lib: skip if not below kernel version Matthieu Baerts
2023-06-13 0:00 ` patchwork-bot+netdevbpf [this message]
2023-06-10 16:11 ` [PATCH net 02/17] selftests: mptcp: join: use 'iptables-legacy' if available Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 03/17] selftests: mptcp: join: helpers to skip tests Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 04/17] selftests: mptcp: join: skip check if MIB counter not supported Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 05/17] selftests: mptcp: join: skip test if iptables/tc cmds fail Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 06/17] selftests: mptcp: join: support local endpoint being tracked or not Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 07/17] selftests: mptcp: join: skip Fastclose tests if not supported Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 08/17] selftests: mptcp: join: support RM_ADDR for used endpoints or not Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 09/17] selftests: mptcp: join: skip implicit tests if not supported Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 10/17] selftests: mptcp: join: skip backup if set flag on ID " Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 11/17] selftests: mptcp: join: skip fullmesh flag tests if " Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 12/17] selftests: mptcp: join: skip userspace PM " Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 13/17] selftests: mptcp: join: skip fail " Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 14/17] selftests: mptcp: join: skip MPC backups " Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 15/17] selftests: mptcp: join: skip PM listener " Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 16/17] selftests: mptcp: join: uniform listener tests Matthieu Baerts
2023-06-10 16:11 ` [PATCH net 17/17] selftests: mptcp: join: skip mixed tests if not supported Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168661442392.10094.4616497599019441750.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang.tang@suse.com \
--cc=geliangtang@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox