From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932386AbcFTNgT (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jun 2016 09:36:19 -0400
Received: from mailout4.samsung.com ([203.254.224.34]:34141 "EHLO
	mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754395AbcFTNgE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jun 2016 09:36:04 -0400
X-AuditID: cbfee61b-f798b6d00000114d-94-5767f1355178
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>, Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        "linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
        linux-clk@vger.kernel.org,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] clk: samsung: exynos5433: prepare for adding CPU clocks
Date: Mon, 20 Jun 2016 15:35:47 +0200
Message-id: <1687314.R0ikIvAotG@amdc1976>
User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <CA+Ln22GmeuHaNwpHOMxP0SA9-KaJp4D4sM5aF3bVRWm5Xb72fA@mail.gmail.com>
References: <1464095957-25851-1-git-send-email-b.zolnierkie@samsung.com>
 <1464095957-25851-2-git-send-email-b.zolnierkie@samsung.com>
 <CA+Ln22GmeuHaNwpHOMxP0SA9-KaJp4D4sM5aF3bVRWm5Xb72fA@mail.gmail.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset=us-ascii
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRmVeSWpSXmKPExsVy+t9jAV3Tj+nhBms3Gli8fmFo0f/4NbPF
	psfXWC0+9txjtbi8aw6bxYzz+5gsLp5ytTj8pp3V4seZbhaLVbv+MDpweby/0crucbmvl8lj
	56y77B6bVnWyeWxeUu/Rt2UVo8fnTXIB7FFcNimpOZllqUX6dglcGZtvPGEquMVWsWDjXOYG
	xp2sXYycHBICJhKnHnQzQthiEhfurWfrYuTiEBJYyiixa2sXlPOVUaKz8Q0zSBWbgJXExPZV
	YB0iAuoS36b0s4MUMQssZ5b4dPQtG0hCWCBAYtvMRWA2i4CqxMnPW4DWcXDwCmhK3GoC2ywq
	4CXRs/0R2BxOgWCJrlW3WCCWnWOUOHHjNwtIgldAUOLH5HtgNrOAvMS+/VNZIWwtifU7jzNN
	YBSYhaRsFpKyWUjKFjAyr2KUSC1ILihOSs81ykst1ytOzC0uzUvXS87P3cQIjo1n0jsYD+9y
	P8QowMGoxMM7QzE9XIg1say4MvcQowQHs5IIr8J7oBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHe
	x//XhQkJpCeWpGanphakFsFkmTg4pRoYNYUEfl6OrshN5a9cKcWaEDPR1NZg0UJ7D9nt4kGJ
	kk0XH67xql/FvHrNld3nLBveMpXItwe6l228sNJgQirzEZs3Ia2MfzZ4BpmezpvIbev5Lmvh
	RR2OmCfy1+avkP/REvZI8M8DGQ7DDK3MiOX3/6YFV3L4bZ1Q2d9x+eGP/TfmnpvVK7BFiaU4
	I9FQi7moOBEAbLAQCYkCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Tomasz,

On Saturday, June 18, 2016 11:40:05 PM Tomasz Figa wrote:
> Hi Bartlomiej,
> 
> 2016-05-24 22:19 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> > Open-code samsung_cmu_register_one() calls for CMU_APOLLO and
> > CMU_ATLAS setup code as a preparation for adding CPU clocks
> > support for Exynos5433.
> 
> Why do we need to open code it? Even if it's really necessary, it

We want to register CPU clock before calling samsung_clk_sleep_init()
and samsung_clk_of_add_provider() (just as we do it on other Exynos
SoCs) so we cannot use samsung_cmu_register_one() helper.

> would make sense to state it in the commit description for lazy
> readers reviewing the patches in order. :)

Right, sorry about that.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics