From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbcBUShu (ORCPT ); Sun, 21 Feb 2016 13:37:50 -0500 Received: from titan.allfex.org ([5.9.57.113]:51383 "EHLO titan.allfex.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbcBUSht (ORCPT ); Sun, 21 Feb 2016 13:37:49 -0500 X-Greylist: delayed 4200 seconds by postgrey-1.27 at vger.kernel.org; Sun, 21 Feb 2016 13:37:48 EST From: Markus Pargmann To: nbd-general@lists.sourceforge.net Cc: Dmitry Monakhov , linux-kernel@vger.kernel.org Subject: Re: [Nbd] [PATCH] nbd: ratelimit error messages from disconnected devices Date: Sun, 21 Feb 2016 14:48:08 +0100 Message-ID: <1689019.lyAuorBep0@galactica> User-Agent: KMail/4.14.10 (Linux/4.4.0-trunk-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1455618781-26306-1-git-send-email-dmonakhov@openvz.org> References: <1455618781-26306-1-git-send-email-dmonakhov@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3501959.TTdFXiyiDP"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3501959.TTdFXiyiDP Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi, On Tuesday 16 February 2016 14:33:01 Dmitry Monakhov wrote: > ndb can be explicitly disconnected via NBD_DISCONNECT while > active user still exists this result in massive spam to logs. > Let's ratelimits such messages. > > Signed-off-by: Dmitry Monakhov > --- > drivers/block/nbd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > index e4c5cc1..2dbe840 100644 > --- a/drivers/block/nbd.c > +++ b/drivers/block/nbd.c > @@ -175,7 +175,7 @@ static int sock_xmit(struct nbd_device *nbd, int send, void *buf, int size, > unsigned long pflags = current->flags; > > if (unlikely(!sock)) { > - dev_err(disk_to_dev(nbd->disk), > + dev_err_ratelimited(disk_to_dev(nbd->disk), > "Attempted %s on closed socket in sock_xmit\n", Please indent to the first opening bracket. > (send ? "send" : "recv")); > return -EINVAL; > @@ -509,7 +509,7 @@ static void nbd_handle_req(struct nbd_device *nbd, struct request *req) > mutex_lock(&nbd->tx_lock); > if (unlikely(!nbd->sock)) { > mutex_unlock(&nbd->tx_lock); > - dev_err(disk_to_dev(nbd->disk), > + dev_err_ratelimited(disk_to_dev(nbd->disk), > "Attempted send on closed socket\n"); > goto error_out; > } > @@ -618,7 +618,7 @@ static void nbd_request_handler(struct request_queue *q) > req, req->cmd_type); > > if (unlikely(!nbd->sock)) { > - dev_err(disk_to_dev(nbd->disk), > + dev_err_ratelimited(disk_to_dev(nbd->disk), > "Attempted send on closed socket\n"); This conflicts with a patch already applied fixing the same. Please rebase onto nbd master [1] Best Regards, Markus [1] http://git.pengutronix.de/?p=mpa/linux-nbd.git;a=shortlog;h=refs/heads/master --nextPart3501959.TTdFXiyiDP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWycAYAAoJECi9+rkzbKwyZw4QANDLIg/PbGWOgaSs9hfUapit beC8HO9JYTwwv/qCgKxeS2OXt4BeGh8Q9g2ERsp78Mc0Fz5s4gR0VuL9B/yWa8Jl PEsHw584QwzN5e3VkX/a2HUaIXbIfvcXphdHURBlhRSr6OXBF9xS9y6PBNR8WvVV UyIYIwmf0bj0UgyD2OUhw3TEimR/i+Sjb2vNmFRLZZhsUJi6k0U7KnaEPFkWQin0 Lc2cu9SDsCbp7ewLTdd9GtoVtm9p+VanaaWdetgMJGT3n1PR8QKp0IY3oiI9ZMV6 T8QxJbFqaRAoyNSj24Tp3nS3Plw6YA2p2KAt52KqNiQnqOuYmVrkbn0QBqbWAzJw uE6UpQAEhu0b92JGuNLvroe9XGg525zThy7Ka/sorlplrH34Yh0qfGruNNFrLZrF 6EsCB4wo2EQQtWDXS4RcQQ3F4ddstIww1Hm2po9jyEL8X/ap5BgVDppVXW46awMW Jv/2zewka0p5QKd5JpnwQFtH1akY1Bwiog9HuXCI3/pAT35Yr0iusZaRo7w/o8I4 ot4GOYoMeONWXBsbtQxv/gKeBGiSOkpglgY4usmBI4G/1+I7sUOqmoDZ0NZGNJWY geqMPQXjTti0Js7vqDM3O3Tk1lPItRO1X9txx0ObsVXn5Qkr6HONxFx+RFRv0XoM tcERaFLEfqwE3U0+CD+s =XVnN -----END PGP SIGNATURE----- --nextPart3501959.TTdFXiyiDP--