Re: [PATCH net] net: ethernet: mtk_eth_soc: always mtk_get_ib1_pkt_type

Lorenzo Bianconi
2023-07-19T07:47:33Z

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

> entries and bind debugfs files would display wrong data on NETSYS_V2 and
> later because instead of using mtk_get_ib1_pkt_type the driver would use
> MTK_FOE_IB1_PACKET_TYPE which corresponds to NETSYS_V1(.x) SoCs.
> Use mtk_get_ib1_pkt_type so entries and bind records display correctly.
>
> Fixes: 03a3180e5c09e ("net: ethernet: mtk_eth_soc: introduce flow offloading support for mt7986")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> ---
> drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c b/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c
> index 316fe2e70fead..1a97feca77f23 100644
> --- a/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c
> +++ b/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c
> @@ -98,7 +98,7 @@ mtk_ppe_debugfs_foe_show(struct seq_file *m, void *private, bool bind)
>
> acct = mtk_foe_entry_get_mib(ppe, i, NULL);
>
> - type = FIELD_GET(MTK_FOE_IB1_PACKET_TYPE, entry->ib1);
> + type = mtk_get_ib1_pkt_type(ppe->eth, entry->ib1);
> seq_printf(m, "%05x %s %7s", i,
> mtk_foe_entry_state_str(state),
> mtk_foe_pkt_type_str(type));
> --
> 2.41.0
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]