From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D64BC71131 for ; Fri, 18 Aug 2023 00:11:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356636AbjHRAKv (ORCPT ); Thu, 17 Aug 2023 20:10:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356668AbjHRAKg (ORCPT ); Thu, 17 Aug 2023 20:10:36 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56A483C0A for ; Thu, 17 Aug 2023 17:10:18 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-c6dd0e46a52so442444276.2 for ; Thu, 17 Aug 2023 17:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692317417; x=1692922217; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RGYnYnVbUYYSVjFpVMoKW4GyT9YCBE6+MRRcctXwEms=; b=OwwpahlSHn2WsIv1jkm4dgZeh3mellgfhBb+bvzTHjWkiT+62ofbR17Ov4Vln/EL95 +GZK48JqTNYW8cVAOeMYt0FYg7M7t014+KHZMsKaktOCA0yzf6qzJvkrc0KdxNgwSpOi i5jgTWnJXc07CQC4ahI2mJT+F8kg3Gc0yeQTWWmrX2Au+8wMspjdo6FTFSJszTF3m13p +Qjr/EBF5Y8m+9rLgXZIOz1ZohfkR8EHgonAVSAqhQd+R4g/EpPnhQ6EnRVEM44/4HKU LHfU+8kMBuA9Qz4IrWdO4O/gADP2+fggFNyyAIhH9UaTYVZ/JxxdDvvIQOpDRvrBmJbH YrEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692317417; x=1692922217; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RGYnYnVbUYYSVjFpVMoKW4GyT9YCBE6+MRRcctXwEms=; b=P3A6Ppt3GC6BZ10ELcEGDIwTG2GxRZ6B2KGMXlmXXX1Ia0D4AgpevHTQ6fvY8ENR0U XHmToVbiyWkL3nIS/2EGRSq1FC2K40SLRGtgdc6A43YLei4HHqsZkf3EkkNA+GCq9hiK a2OQDMDb6cLMAs592Bv2myqorBk0QG0fjPj7JGIeWVlu/5tIP+ZaLS1MbzajBld457so bsVexg4zn6P++bQIN9666qpHGF2QIToqXXQsJLzx0EDSYMWcH3th6D/Gf3pwc4TVXA1L ehI1SaQwxbaO/LDjtTdw9Xrgi4n9JZG627vRwjfF41F0SDg/kUZ0BUkwHH+0HaOOZL6a UcOg== X-Gm-Message-State: AOJu0YyMUelAELnLuiGvR+Mlo3VgmE4Q5JnXLH0Bot+HCEgyCNcIAxbj HaZFoV5SQQlXRoC4cHb4tw0XZ2xftwE= X-Google-Smtp-Source: AGHT+IFqs4TVheY2Zgf/ctECuRnI/YyIKKz9RpWYLL1cdECAJN9/STpqQHHXgnjfGW+ewzuoY9b6f0Ta13Q= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:1813:b0:d0c:1f08:5fef with SMTP id cf19-20020a056902181300b00d0c1f085fefmr13826ybb.12.1692317417588; Thu, 17 Aug 2023 17:10:17 -0700 (PDT) Date: Thu, 17 Aug 2023 17:09:22 -0700 In-Reply-To: <20230808232057.2498287-1-seanjc@google.com> Mime-Version: 1.0 References: <20230808232057.2498287-1-seanjc@google.com> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog Message-ID: <169229705756.1237266.17952019495946517627.b4-ty@google.com> Subject: Re: [PATCH] KVM: x86: Remove WARN sanity check on hypervisor timer vs. UNINITIALIZED vCPU From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yikebaer Aizezi Content-Type: text/plain; charset="utf-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 08 Aug 2023 16:20:57 -0700, Sean Christopherson wrote: > Drop the WARN in KVM_RUN that asserts that KVM isn't using the hypervisor > timer, a.k.a. the VMX preemption timer, for a vCPU that is in the > UNINITIALIZIED activity state. The intent of the WARN is to sanity check > that KVM won't drop a timer interrupt due to an unexpected transition to > UNINITIALIZED, but unfortunately userspace can use various ioctl()s to > force the unexpected state. > > [...] Applied to kvm-x86 misc, with a tweaked comment to avoid "smother". [1/1] KVM: x86: Remove WARN sanity check on hypervisor timer vs. UNINITIALIZED vCPU https://github.com/kvm-x86/linux/commit/7b0151caf73a -- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes