From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93914EE49B0 for ; Wed, 23 Aug 2023 08:56:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234696AbjHWI4B (ORCPT ); Wed, 23 Aug 2023 04:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234907AbjHWIxc (ORCPT ); Wed, 23 Aug 2023 04:53:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E719198A for ; Wed, 23 Aug 2023 01:50:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B463965871 for ; Wed, 23 Aug 2023 08:50:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id D141BC43395; Wed, 23 Aug 2023 08:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692780622; bh=D59qyq58UezOttgdWtESqgR1cWRWfhp0fLfSQcwW5b0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=s29Oj2Vn6Y/etE5V4qIM4XmlsVUEBUi8axTHTrt9o706JSONZLdnWC3CTeIwvMBYP 7mdcW0+m0skTxWYwMvtgfTCzpNgRb/EPVsl9SUgIexWTiF4iRZNThk4/5C7C6F7yqz mkbUiEayrhJzp8N/GG3uxG7zv0y41fOYKmFkM3+C1HlgS8iq1YJzL6OpM8qSDqM7hg otRVpAGr8kSWnYVfnvBIDntBHUmLxaa7EFXGj/hm1cks+RsFpZADp6lhAUu0G3FegL mSdmkfKfc1agGQoJ+A6lHwcQmSWCBx6RSFxHSrNn43gt6Ug4CTKHbUUlu7YLo97KMS 1gVofXoic1PWw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id B9D7DE330A1; Wed, 23 Aug 2023 08:50:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v3] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169278062275.13745.14874894207832456687.git-patchwork-notify@kernel.org> Date: Wed, 23 Aug 2023 08:50:22 +0000 References: <20230821142713.5062-1-feliu@nvidia.com> In-Reply-To: <20230821142713.5062-1-feliu@nvidia.com> To: Feng Liu Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jasowang@redhat.com, mst@redhat.com, xuanzhuo@linux.alibaba.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net, willemdebruijn.kernel@gmail.com, horms@kernel.org, bodong@nvidia.com, jiri@nvidia.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Mon, 21 Aug 2023 10:27:13 -0400 you wrote: > The virtio_net driver currently deals with different versions and types > of virtio net headers, such as virtio_net_hdr_mrg_rxbuf, > virtio_net_hdr_v1_hash, etc. Due to these variations, the code relies > on multiple type casts to convert memory between different structures, > potentially leading to bugs when there are changes in these structures. > > Introduces the "struct skb_vnet_common_hdr" as a unifying header > structure using a union. With this approach, various virtio net header > structures can be converted by accessing different members of this > structure, thus eliminating the need for type casting and reducing the > risk of potential bugs. > > [...] Here is the summary with links: - [net-next,v3] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting https://git.kernel.org/netdev/net-next/c/dae64749db25 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html